Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 889553003: Revert of Componentize WebHistoryService (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, extensions-reviews_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, rlp+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Componentize WebHistoryService (patchset #4 id:60001 of https://codereview.chromium.org/882753002/) Reason for revert: BUG=454524 Original issue's description: > Componentize WebHistoryService > > Instead of using the factories to retrieve the dependended upon keyed service, > pass them explicitly to WebHistoryService from the WebHistoryServiceFactory. > > Fix the dependency of WebHistoryService to add the service used and to remove > the service unused. > > Move file into //components/history/core/browser, remove unnecessary #include > and fix files that did not #include all the files they used. > > BUG=371835 > > Committed: https://crrev.com/12dabec1af75b80952821fee2f37a28637fa15b7 > Cr-Commit-Position: refs/heads/master@{#313926} TBR=droger@chromium.org,jhawkins@chromium.org,rlp@chromium.org,rogerta@chromium.org,sdefresne@chromium.org NOPRESUBMIT=true BUG=371835 Committed: https://crrev.com/014d6bff6fb63d89847be0431aaaa985a852801c Cr-Commit-Position: refs/heads/master@{#314240}

Patch Set 1 #

Patch Set 2 : Mon Feb 2 14:34:37 PST 2015 #

Patch Set 3 : Mon Feb 2 14:36:57 PST 2015 #

Patch Set 4 : Mon Feb 2 14:50:05 PST 2015 #

Patch Set 5 : Mon Feb 2 15:10:48 PST 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -781 lines) Patch
M chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
A + chrome/browser/history/web_history_service.h View 1 5 chunks +7 lines, -21 lines 0 comments Download
A + chrome/browser/history/web_history_service.cc View 1 10 chunks +35 lines, -34 lines 0 comments Download
M chrome/browser/history/web_history_service_factory.cc View 1 2 chunks +11 lines, -18 lines 0 comments Download
M chrome/browser/history/web_history_service_unittest.cc View 1 13 chunks +26 lines, -25 lines 0 comments Download
M chrome/browser/search/hotword_audio_history_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/hotword_service_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/history.gypi View 1 3 chunks +0 lines, -4 lines 0 comments Download
M components/history/DEPS View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 1 2 chunks +0 lines, -4 lines 0 comments Download
D components/history/core/browser/web_history_service.h View 1 1 chunk +0 lines, -179 lines 0 comments Download
D components/history/core/browser/web_history_service.cc View 1 1 chunk +0 lines, -478 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Vitaly Buka (NO REVIEWS)
Created Revert of Componentize WebHistoryService
5 years, 10 months ago (2015-02-02 22:27:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889553003/1
5 years, 10 months ago (2015-02-02 22:28:13 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/history/history_service.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-02 22:29:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889553003/290001
5 years, 10 months ago (2015-02-02 22:41:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889553003/310001
5 years, 10 months ago (2015-02-02 22:52:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/38366)
5 years, 10 months ago (2015-02-02 23:02:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889553003/330001
5 years, 10 months ago (2015-02-02 23:13:43 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:330001)
5 years, 10 months ago (2015-02-03 01:47:24 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 01:48:37 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/014d6bff6fb63d89847be0431aaaa985a852801c
Cr-Commit-Position: refs/heads/master@{#314240}

Powered by Google App Engine
This is Rietveld 408576698