Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

Issue 889553002: dart2js: remove unused parameter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
index e79e424e656d1975df979157d4d2a51211ad82eb..40b203c9ba148bef8d3835378b5f2a783356b2c2 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
@@ -22,8 +22,7 @@ class ContainerBuilder extends CodeEmitterHelper {
*/
void addParameterStub(FunctionElement member,
Selector selector,
- AddStubFunction addStub,
- Set<String> alreadyGenerated) {
+ AddStubFunction addStub) {
FunctionSignature parameters = member.functionSignature;
int positionalArgumentCount = selector.positionalArgumentCount;
if (positionalArgumentCount == parameters.parameterCount) {
@@ -40,10 +39,6 @@ class ContainerBuilder extends CodeEmitterHelper {
JavaScriptConstantCompiler handler = backend.constants;
List<String> names = selector.getOrderedNamedArguments();
- String invocationName = namer.invocationName(selector);
- if (alreadyGenerated.contains(invocationName)) return;
- alreadyGenerated.add(invocationName);
-
bool isInterceptedMethod = backend.isInterceptedMethod(member);
// If the method is intercepted, we need to also pass the actual receiver.
@@ -60,6 +55,7 @@ class ContainerBuilder extends CodeEmitterHelper {
List<jsAst.Expression> argumentsBuffer =
new List<jsAst.Expression>(
parameters.parameterCount + extraArgumentCount);
+ String invocationName = namer.invocationName(selector);
int count = 0;
if (isInterceptedMethod) {
@@ -217,8 +213,7 @@ class ContainerBuilder extends CodeEmitterHelper {
for (Selector selector in selectors) {
if (!selector.appliesUnnamed(member, compiler.world)) continue;
if (untypedSelectors.add(selector.asUntyped)) {
- // TODO(ahe): Is the last argument to [addParameterStub] needed?
- addParameterStub(member, selector, defineStub, new Set<String>());
+ addParameterStub(member, selector, defineStub);
}
}
}
@@ -232,8 +227,7 @@ class ContainerBuilder extends CodeEmitterHelper {
selector.argumentCount, selector.namedArguments);
if (!selector.appliesUnnamed(member, compiler.world)) continue;
if (untypedSelectors.add(selector)) {
- // TODO(ahe): Is the last argument to [addParameterStub] needed?
- addParameterStub(member, selector, defineStub, new Set<String>());
+ addParameterStub(member, selector, defineStub);
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698