Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889533004: Add UseCounters for the reflected SVGElement.xml* attributes (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
CC:
blink-reviews, krit, arv+blink, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), Inactive, gyuyoung.kim_webkit.org, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add UseCounters for the reflected SVGElement.xml* attributes Erik Dahlström <ed@opera.com>; is going to propose dropping these: https://www.w3.org/Graphics/SVG/WG/wiki/Proposals/dropxmlattributes BUG=341854 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
philipj_slow
PTAL. Depends on https://codereview.chromium.org/890863003/
5 years, 10 months ago (2015-01-30 15:27:02 UTC) #2
Erik Dahlström (inactive)
LGTM
5 years, 10 months ago (2015-01-30 15:31:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889533004/1
5 years, 10 months ago (2015-01-30 16:40:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/48538)
5 years, 10 months ago (2015-01-30 18:30:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889533004/1
5 years, 10 months ago (2015-01-30 19:45:23 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 19:45:59 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189278

Powered by Google App Engine
This is Rietveld 408576698