Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 889533002: Revert "Enable Roboto by default for testing purpose." (Closed)

Created:
5 years, 10 months ago by perkj_chrome
Modified:
5 years, 10 months ago
Reviewers:
CC:
chromium-reviews, stevenjb+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Enable Roboto by default for testing purpose." This reverts commit b138032ecd37b1225ac200f561d6232d423dd89a. This seems to make RenderTextTest.TextDoesntClip to fail on Chrome OS Asan /Lsan. http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6266 BUG=448948 TBR=xdai1@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/86f137da601b3604c3b487db7f2745285c8be067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/chromeos/oobe_webui_browsertest.js View 2 chunks +0 lines, -13 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/font_helper_chromeos.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/font_helper_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86f137da601b3604c3b487db7f2745285c8be067 Cr-Commit-Position: refs/heads/master@{#313686}
5 years, 10 months ago (2015-01-29 09:35:33 UTC) #1
perkj_chrome
5 years, 10 months ago (2015-01-29 09:35:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86f137da601b3604c3b487db7f2745285c8be067 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698