ImportDefault, ImportBookmarksFile and ImportNothingAndShowNewTabPage tests are failing consistentl…

ImportDefault, ImportBookmarksFile and ImportNothingAndShowNewTabPage tests are failing consistently on official MacOSX builder. Disabling it for now until it is fixed to keep the official bot green.

BUG=314221
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238541

[cpu_(ooo_6.6-7.5), 2013-11-27 01:07:55]

I don't know anything about this code anymore. Adding gab to the review.

[gab, 2013-11-27 19:53:29]

On 2013/11/27 01:07:55, cpu wrote:
> I don't know anything about this code anymore. Adding gab to the review.

This appears to be a duplicate of https://codereview.chromium.org/54643009/.

[pshenoy, 2013-12-03 18:00:11]

On 2013/11/27 19:53:29, gab wrote:
> On 2013/11/27 01:07:55, cpu wrote:
> > I don't know anything about this code anymore. Adding gab to the review.
> 
> This appears to be a duplicate of https://codereview.chromium.org/54643009/.

These tests have been failing for log time on this bot. Also I don't see any
builds in the recent past on 8011 builder where these tests have passed. So
disabling it until it is fixed.

[gab, 2013-12-03 18:31:54]

Ok, but can we close this issue or the its duplicate? There are now two issues
up for the same thing...

I will look into those tests locally now, I don't like just disabling them cause
no one will ever fix them if we do that...

https://codereview.chromium.org/88953002/diff/1/chrome/browser/first_run/firs...
File chrome/browser/first_run/first_run_browsertest.cc (right):

https://codereview.chromium.org/88953002/diff/1/chrome/browser/first_run/firs...
chrome/browser/first_run/first_run_browsertest.cc:218:
DISABLED_ImportNothingAndShowNewTabPage
nit: align DISABLED with MAYBE above.

[gab, 2013-12-03 18:32:05]

Ok, but can we close this issue or the its duplicate? There are now two issues
up for the same thing...

I will look into those tests locally now, I don't like just disabling them cause
no one will ever fix them if we do that...

[pshenoy, 2013-12-03 19:20:25]

On 2013/12/03 18:32:05, gab wrote:
> Ok, but can we close this issue or the its duplicate? There are now two issues
> up for the same thing...
> 
> I will look into those tests locally now, I don't like just disabling them
cause
> no one will ever fix them if we do that...

Sure. We can close the duplicate.

[pshenoy, 2013-12-03 19:20:49]

https://codereview.chromium.org/88953002/diff/1/chrome/browser/first_run/firs...
File chrome/browser/first_run/first_run_browsertest.cc (right):

https://codereview.chromium.org/88953002/diff/1/chrome/browser/first_run/firs...
chrome/browser/first_run/first_run_browsertest.cc:218:
DISABLED_ImportNothingAndShowNewTabPage
On 2013/12/03 18:31:55, gab wrote:
> nit: align DISABLED with MAYBE above.
I think it should be four space indent.

[gab, 2013-12-03 19:37:24]

lgtm if you find a Mac owner for the bug and make it P1 + ReleaseBlocker.
Disabling tests with no owner means they will never be re-enabled...

Looks it's failing in the IPC communication with the import process; this could
be highlighting an actual product bug.

Also please close duplicate CL @ https://codereview.chromium.org/54643009/

Thanks,
Gab

https://codereview.chromium.org/88953002/diff/1/chrome/browser/first_run/firs...
File chrome/browser/first_run/first_run_browsertest.cc (right):

https://codereview.chromium.org/88953002/diff/1/chrome/browser/first_run/firs...
chrome/browser/first_run/first_run_browsertest.cc:218:
DISABLED_ImportNothingAndShowNewTabPage
On 2013/12/03 19:20:49, pshenoy wrote:
> On 2013/12/03 18:31:55, gab wrote:
> > nit: align DISABLED with MAYBE above.
> I think it should be four space indent. 

Just grep'ed the codebase and it looks like this is indeed fine (about 60% of
the codebase is 4 spaces and the rest is aligned in this scenario).

[commit-bot: I haz the power, 2013-12-03 20:55:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pshenoy@chromium.org/88953002/20001

[commit-bot: I haz the power, 2013-12-03 23:41:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pshenoy@chromium.org/88953002/20001

[commit-bot: I haz the power, 2013-12-04 03:13:52]

Change committed as 238541