Source/WebKit/chromium/src/WebViewImpl.cpp - Issue 8895026: Revert 96912 - Always call setActive() in WebViewImpl::setFocus(),

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebViewImpl.cpp

Issue 8895026: Revert 96912 - Always call setActive() in WebViewImpl::setFocus(), (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebKit/chromium/src/WebViewImpl.cpp

===================================================================

--- Source/WebKit/chromium/src/WebViewImpl.cpp (revision 102682)

+++ Source/WebKit/chromium/src/WebViewImpl.cpp (working copy)

@@ -1423,8 +1423,10 @@

void WebViewImpl::setFocus(bool enable)

{

m_page->focusController()->setFocused(enable);

- m_page->focusController()->setActive(enable);

if (enable) {

+ // Note that we don't call setActive() when disabled as this cause extra

+ // focus/blur events to be dispatched.

+ m_page->focusController()->setActive(true);

RefPtr<Frame> focusedFrame = m_page->focusController()->focusedFrame();

if (focusedFrame) {

Node* focusedNode = focusedFrame->document()->focusedNode();

« no previous file with comments | « Source/WebKit/chromium/WebKit.gypi ('k') | Source/WebKit/chromium/tests/WebFrameTest.cpp » ('j') | no next file with comments »