Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2392)

Unified Diff: content/child/webcrypto/openssl/pbkdf2_openssl.cc

Issue 889493002: Allow PBKDF2 key derivation using an empty password. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/webcrypto/status.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/openssl/pbkdf2_openssl.cc
diff --git a/content/child/webcrypto/openssl/pbkdf2_openssl.cc b/content/child/webcrypto/openssl/pbkdf2_openssl.cc
index 9f3017b52323ad57aa188b70d0628fada278483b..d7ce4856a2bfdb1bde4666d41f6e4e65a2e0130d 100644
--- a/content/child/webcrypto/openssl/pbkdf2_openssl.cc
+++ b/content/child/webcrypto/openssl/pbkdf2_openssl.cc
@@ -75,14 +75,6 @@ class Pbkdf2Implementation : public AlgorithmImplementation {
const std::vector<uint8_t>& password =
SymKeyOpenSsl::Cast(base_key)->raw_key_data();
- // TODO(xun.sun): Empty password would derive random keys with
- // PKCS5_PBKDF2_HMAC().
- // https://code.google.com/p/chromium/issues/detail?id=449409
- //
- // Rejecting them until it is addressed in BoringSSL.
- if (password.empty())
- return Status::ErrorPbkdf2EmptyPassword();
-
if (keylen_bytes == 0)
return Status::Success();
« no previous file with comments | « no previous file | content/child/webcrypto/status.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698