chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc - Issue 889483003: Disable AutofillPopupControllerBrowserTest.DoNotHidePopupOnWindowMove on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

Issue 889483003: Disable AutofillPopupControllerBrowserTest.DoNotHidePopupOnWindowMove on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

index 7ba0e02ce3a231b641bbda3b56492f496651ef41..75cdeb1000055be159186f85bdfbf3976e94a110 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

@@ -96,8 +96,14 @@ class AutofillPopupControllerBrowserTest

scoped_ptr<TestAutofillExternalDelegate> autofill_external_delegate_;

};

+#if defined(OS_MACOSX)

+// Fails on Mac OS, see crbug/453256

+#define MAYBE_DoNotHidePopupOnWindowMove DISABLED_DoNotHidePopupOnWindowMove

+#else

+#define MAYBE_DoNotHidePopupOnWindowMove DoNotHidePopupOnWindowMove

+#endif

IN_PROC_BROWSER_TEST_F(AutofillPopupControllerBrowserTest,

- DoNotHidePopupOnWindowMove) {

+ MAYBE_DoNotHidePopupOnWindowMove) {

GenerateTestAutofillPopup(autofill_external_delegate_.get());

EXPECT_FALSE(autofill_external_delegate_->popup_hidden());

« no previous file with comments | « no previous file | no next file » | no next file with comments »