Issue 889473002: bookmarks: Cleanup - remove unused variables left behind after refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 889473002: bookmarks: Cleanup - remove unused variables left behind after refactoring. (Closed)

Created:
5 years, 10 months ago by tfarina

Modified:
5 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, blundell

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

bookmarks: Cleanup - remove unused variables left behind after refactoring. These variables were left unused after https://chromium.googlesource.com/chromium/src/+/23e63803fbf9a7aaf0a6107e36ea9c2ef6857d95%5E%21/#F1 BUG=None TEST=components_unittests --gtest_filter=BookmarkCodecTest.* R=sky@chromium.org Committed: https://crrev.com/d028dec8288f8f1c47618b866f11b0a4d57e9f20 Cr-Commit-Position: refs/heads/master@{#313908}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	components/bookmarks/browser/bookmark_codec_unittest.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889473002/1

5 years, 10 months ago (2015-01-30 13:55:03 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-01-30 13:59:28 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d028dec8288f8f1c47618b866f11b0a4d57e9f20
Cr-Commit-Position: refs/heads/master@{#313908}