Issue 889453006: [Password manager tests] Makes logs which we pass to sheet cleaner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 889453006: [Password manager tests] Makes logs which we pass to sheet cleaner. (Closed)

Created:
5 years, 10 months ago by melandory

Modified:
5 years, 10 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Password manager tests] Makes logs which we pass to sheet cleaner. Instead of logging full exception we log only message. R=vabr@chromium.org BUG=435249 Committed: https://crrev.com/633c90170a5969e554d0e3389d551516cdaa6744 Cr-Commit-Position: refs/heads/master@{#313735}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	components/test/data/password_manager/automated_tests/environment.py	View		2 chunks	+4 lines, -6 lines	0 comments	Download

Total messages: 6 (1 generated)

melandory

Hi Vaclav, review this CL, please. If you want I can show you difference between ...

5 years, 10 months ago (2015-01-29 10:15:54 UTC) #1

vabr (Chromium)

LGTM, this looks very reasonable. I remember having trouble reading the old error messages. Thanks ...

5 years, 10 months ago (2015-01-29 14:24:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889453006/1

5 years, 10 months ago (2015-01-29 17:09:54 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 18:11:22 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/633c90170a5969e554d0e3389d551516cdaa6744
Cr-Commit-Position: refs/heads/master@{#313735}