Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 889453004: Tab, TabStrip: Added GetClassName override. (Closed)

Created:
5 years, 10 months ago by Matt Giuca
Modified:
5 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tab, TabStrip: Added GetClassName override. This helps with debugging a TabbedPane views hierarchy as you can print the proper class names of Tabs and TabStrips inside. Committed: https://crrev.com/bca7a2e37c3007cbf1dbcfd9f387479fe66630be Cr-Commit-Position: refs/heads/master@{#313672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 7 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
Just something I found helpful for debugging; may as well be in the codebase.
5 years, 10 months ago (2015-01-29 04:57:18 UTC) #2
sadrul
lgtm
5 years, 10 months ago (2015-01-29 05:18:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889453004/1
5 years, 10 months ago (2015-01-29 06:11:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 06:56:39 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 06:57:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bca7a2e37c3007cbf1dbcfd9f387479fe66630be
Cr-Commit-Position: refs/heads/master@{#313672}

Powered by Google App Engine
This is Rietveld 408576698