Service isolate rework take 2

runtime/vm/unit_test.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_UNIT_TEST_H_
 #define VM_UNIT_TEST_H_
 
 #include "include/dart_native_api.h"
 
 #include "platform/globals.h"
@@ skipping 246 matching lines @@
 
   static Dart_Handle LoadTestScript(const char* script,
                                     Dart_NativeEntryResolver resolver,
                                     const char* lib_uri = USER_TEST_URI,
                                     bool finalize = true);
 
   static Dart_Handle LoadCoreTestScript(const char* script,
                                         Dart_NativeEntryResolver resolver);
   static Dart_Handle lib();
   static const char* url() { return USER_TEST_URI; }
-  static Dart_Isolate CreateTestIsolateFromSnapshot(uint8_t* buffer) {
-    return CreateIsolate(buffer);
+  static Dart_Isolate CreateTestIsolateFromSnapshot(
+      uint8_t* buffer, const char* name = NULL) {
+    return CreateIsolate(buffer, name);
   }
-  static Dart_Isolate CreateTestIsolate() {
-    return CreateIsolate(bin::snapshot_buffer);
+  static Dart_Isolate CreateTestIsolate(const char* name = NULL) {
+    return CreateIsolate(bin::snapshot_buffer, name);
   }
   static Dart_Handle library_handler(Dart_LibraryTag tag,
                                      Dart_Handle library,
                                      Dart_Handle url);
   static char* BigintToHexValue(Dart_CObject* bigint);
 
   virtual void Run();
 
  private:
-  static Dart_Isolate CreateIsolate(const uint8_t* buffer) {
+  static Dart_Isolate CreateIsolate(const uint8_t* buffer,
+                                    const char* name) {
     char* err;
-    Dart_Isolate isolate = Dart_CreateIsolate(NULL, NULL, buffer, NULL, &err);
+    Dart_Isolate isolate = Dart_CreateIsolate(name, NULL, buffer, NULL, &err);
     if (isolate == NULL) {
       OS::Print("Creation of isolate failed '%s'\n", err);
       free(err);
     }
     EXPECT(isolate != NULL);
     return isolate;
   }
 
   RunEntry* const run_;
 };
@@ skipping 123 matching lines @@
       }                                                                        \
     } else {                                                                   \
       dart::Expect(__FILE__, __LINE__).Fail("expected True, but was '%s'\n",   \
           #handle);                                                            \
     }                                                                          \
   } while (0)
 
 }  // namespace dart
 
 #endif  // VM_UNIT_TEST_H_