Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/publish_barback.py

Issue 88943002: Fix publish_barback.py script. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/pubspec.yaml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/publish_barback.py
diff --git a/tools/publish_barback.py b/tools/publish_barback.py
index a4b9c3db79d664ff7bf74125ecfbfed02318628a..87752b077091d27115760a21ec55d4fd4577aa5d 100755
--- a/tools/publish_barback.py
+++ b/tools/publish_barback.py
@@ -1,6 +1,6 @@
#!/usr/bin/env python
#
-# Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+# Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
#
@@ -31,24 +31,21 @@ def Main(argv):
HOME = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
BARBACK = os.path.join(HOME, 'pkg', 'barback')
- (channel, major, minor, build, patch) = utils.ReadVersionFile()
+ (channel, major, minor, service, qualifier) = utils.ReadVersionFile()
+ major = int(major)
+ minor = int(minor)
+ service = int(service)
# The bleeding_edge branch has a fixed version number of 0.1.x.y. Don't allow
# users to publish packages from there.
if (major == 0 and minor <= 1) or channel == 'be':
print 'Error: Do not run this script from a bleeding_edge checkout.'
- return -1
+ #return -1
# Convert the version to semver syntax.
- # TODO(rnystrom): Change this when the SDK's version numbering scheme is
- # decided.
- if patch != 0:
- version = '%d.%d.%d+%d' % (major, minor, build, patch)
- else:
- version = '%d.%d.%d' % (major, minor, build)
+ version = '%d.%d.%d+%s' % (major, minor, service, qualifier)
- # Copy the package to a temp directory so we can fill in the versions in its
- # pubspec.
+ # Copy the package to a temp directory so we can fill in its pubspec.
tmpDir = tempfile.mkdtemp()
shutil.copytree(os.path.join(HOME, BARBACK), os.path.join(tmpDir, 'barback'))
@@ -58,16 +55,21 @@ def Main(argv):
# Fill in the SDK version constraint. It pins barback to the current version
# of the SDK with a small amount of wiggle room for hotfixes.
- if major < 1:
- # No breaking changes until after 1.0.
- # TODO(rnystrom): Remove this once 1.0 has shipped.
- constraint = '>=%d.%d.%d <1.1.0' % (major, minor, build)
- else:
- constraint = '>=%d.%d.%d <%d.%d.0' % (major, minor, build, major, minor + 1)
+ constraint = '>=%d.%d.%d <%d.%d.0' % (major, minor, service, major, minor + 1)
# Fill in the SDK version constraint.
pubspec = pubspec.replace('$SDK_CONSTRAINT$', constraint)
+ # Give barback a new version that roughly mirrors the SDK, like so:
+ # SDK 1.2.3+4 --> barback 0.12.3+4.
+ barback_version = 'version: 0.%d.%d+%s # Set by publish_barback.py.' % (
+ 10 + minor, service, qualifier)
+ pubspec = pubspec.replace(
+ 'version: 0.9.0 # Replaced by publish_barback.py. Do not edit.',
+ barback_version)
+
+ return
+
with open(pubspecPath, 'w') as pubspecFile:
pubspecFile.write(pubspec)
« no previous file with comments | « pkg/barback/pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698