Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: extensions/browser/extension_host.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_host.h ('k') | extensions/browser/extension_host_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_host.cc
diff --git a/extensions/browser/extension_host.cc b/extensions/browser/extension_host.cc
index 3125701f64e72ed86b1e8342ef28d908b9d5caf5..7874528d272ba54f76d1f4c78d462533d2b78fc4 100644
--- a/extensions/browser/extension_host.cc
+++ b/extensions/browser/extension_host.cc
@@ -434,7 +434,7 @@ content::JavaScriptDialogManager* ExtensionHost::GetJavaScriptDialogManager(
void ExtensionHost::AddNewContents(WebContents* source,
WebContents* new_contents,
WindowOpenDisposition disposition,
- const gfx::Rect& initial_pos,
+ const gfx::Rect& initial_rect,
bool user_gesture,
bool* was_blocked) {
// First, if the creating extension view was associated with a tab contents,
@@ -453,7 +453,7 @@ void ExtensionHost::AddNewContents(WebContents* source,
WebContentsDelegate* delegate = associated_contents->GetDelegate();
if (delegate) {
delegate->AddNewContents(
- associated_contents, new_contents, disposition, initial_pos,
+ associated_contents, new_contents, disposition, initial_rect,
user_gesture, was_blocked);
return;
}
@@ -461,7 +461,7 @@ void ExtensionHost::AddNewContents(WebContents* source,
}
delegate_->CreateTab(
- new_contents, extension_id_, disposition, initial_pos, user_gesture);
+ new_contents, extension_id_, disposition, initial_rect, user_gesture);
}
void ExtensionHost::RenderViewReady() {
« no previous file with comments | « extensions/browser/extension_host.h ('k') | extensions/browser/extension_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698