Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4230)

Unified Diff: chrome/browser/ui/webui/chrome_web_contents_handler.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_contents_handler.cc
diff --git a/chrome/browser/ui/webui/chrome_web_contents_handler.cc b/chrome/browser/ui/webui/chrome_web_contents_handler.cc
index c733afe2336243af209f8f41092a17d865769f1b..9b21e212b6b18b7daf432d68b7432b4ec912fe25 100644
--- a/chrome/browser/ui/webui/chrome_web_contents_handler.cc
+++ b/chrome/browser/ui/webui/chrome_web_contents_handler.cc
@@ -72,15 +72,15 @@ WebContents* ChromeWebContentsHandler::OpenURLFromTab(
// Creates a new tab with |new_contents|. |context| is the browser context that
// the browser should be owned by. |source| is the WebContent where the
// operation originated. |disposition| controls how the new tab should be
-// opened. |initial_pos| is the position of the window if a new window is
-// created. |user_gesture| is true if the operation was started by a user
+// opened. |initial_rect| is the position and size of the window if a new window
+// is created. |user_gesture| is true if the operation was started by a user
// gesture.
void ChromeWebContentsHandler::AddNewContents(
content::BrowserContext* context,
WebContents* source,
WebContents* new_contents,
WindowOpenDisposition disposition,
- const gfx::Rect& initial_pos,
+ const gfx::Rect& initial_rect,
bool user_gesture) {
if (!context)
return;
@@ -102,7 +102,7 @@ void ChromeWebContentsHandler::AddNewContents(
chrome::NavigateParams params(browser, new_contents);
params.source_contents = source;
params.disposition = disposition;
- params.window_bounds = initial_pos;
+ params.window_bounds = initial_rect;
params.window_action = chrome::NavigateParams::SHOW_WINDOW;
params.user_gesture = true;
chrome::Navigate(&params);
« no previous file with comments | « chrome/browser/ui/webui/chrome_web_contents_handler.h ('k') | chromecast/browser/android/cast_window_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698