Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.h ('k') | chrome/browser/ui/apps/chrome_app_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tab_util.cc
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index 95511328775b2334527f2d065eb56457a130fbbe..400922144ec68b409456100a7023afd5e221623b 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -171,7 +171,7 @@ base::DictionaryValue* ExtensionTabUtil::OpenTab(
GURL url;
if (params.url.get()) {
- std::string url_string= *params.url;
+ std::string url_string = *params.url;
url = ExtensionTabUtil::ResolvePossiblyRelativeURL(url_string,
function->extension());
if (!url.is_valid()) {
@@ -528,7 +528,7 @@ bool ExtensionTabUtil::IsCrashURL(const GURL& url) {
void ExtensionTabUtil::CreateTab(WebContents* web_contents,
const std::string& extension_id,
WindowOpenDisposition disposition,
- const gfx::Rect& initial_pos,
+ const gfx::Rect& initial_rect,
bool user_gesture) {
Profile* profile =
Profile::FromBrowserContext(web_contents->GetBrowserContext());
@@ -548,7 +548,7 @@ void ExtensionTabUtil::CreateTab(WebContents* web_contents,
params.extension_app_id = extension_id;
params.disposition = disposition;
- params.window_bounds = initial_pos;
+ params.window_bounds = initial_rect;
params.window_action = chrome::NavigateParams::SHOW_WINDOW;
params.user_gesture = user_gesture;
chrome::Navigate(&params);
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.h ('k') | chrome/browser/ui/apps/chrome_app_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698