Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/browser/background/background_contents.h

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_ 5 #ifndef CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_
6 #define CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_ 6 #define CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 18 matching lines...) Expand all
29 public content::NotificationObserver { 29 public content::NotificationObserver {
30 public: 30 public:
31 class Delegate { 31 class Delegate {
32 public: 32 public:
33 // Called by AddNewContents(). Asks the delegate to attach the opened 33 // Called by AddNewContents(). Asks the delegate to attach the opened
34 // WebContents to a suitable container (e.g. browser) or to show it if it's 34 // WebContents to a suitable container (e.g. browser) or to show it if it's
35 // a popup window. If |was_blocked| is non-NULL, then |*was_blocked| will be 35 // a popup window. If |was_blocked| is non-NULL, then |*was_blocked| will be
36 // set to true if the popup gets blocked, and left unchanged otherwise. 36 // set to true if the popup gets blocked, and left unchanged otherwise.
37 virtual void AddWebContents(content::WebContents* new_contents, 37 virtual void AddWebContents(content::WebContents* new_contents,
38 WindowOpenDisposition disposition, 38 WindowOpenDisposition disposition,
39 const gfx::Rect& initial_pos, 39 const gfx::Rect& initial_rect,
40 bool user_gesture, 40 bool user_gesture,
41 bool* was_blocked) = 0; 41 bool* was_blocked) = 0;
42 42
43 protected: 43 protected:
44 virtual ~Delegate() {} 44 virtual ~Delegate() {}
45 }; 45 };
46 46
47 BackgroundContents( 47 BackgroundContents(
48 content::SiteInstance* site_instance, 48 content::SiteInstance* site_instance,
49 int routing_id, 49 int routing_id,
50 int main_frame_routing_id, 50 int main_frame_routing_id,
51 Delegate* delegate, 51 Delegate* delegate,
52 const std::string& partition_id, 52 const std::string& partition_id,
53 content::SessionStorageNamespace* session_storage_namespace); 53 content::SessionStorageNamespace* session_storage_namespace);
54 ~BackgroundContents() override; 54 ~BackgroundContents() override;
55 55
56 content::WebContents* web_contents() const { return web_contents_.get(); } 56 content::WebContents* web_contents() const { return web_contents_.get(); }
57 virtual const GURL& GetURL() const; 57 virtual const GURL& GetURL() const;
58 58
59 // content::WebContentsDelegate implementation: 59 // content::WebContentsDelegate implementation:
60 void CloseContents(content::WebContents* source) override; 60 void CloseContents(content::WebContents* source) override;
61 bool ShouldSuppressDialogs(content::WebContents* source) override; 61 bool ShouldSuppressDialogs(content::WebContents* source) override;
62 void DidNavigateMainFramePostCommit(content::WebContents* tab) override; 62 void DidNavigateMainFramePostCommit(content::WebContents* tab) override;
63 void AddNewContents(content::WebContents* source, 63 void AddNewContents(content::WebContents* source,
64 content::WebContents* new_contents, 64 content::WebContents* new_contents,
65 WindowOpenDisposition disposition, 65 WindowOpenDisposition disposition,
66 const gfx::Rect& initial_pos, 66 const gfx::Rect& initial_rect,
67 bool user_gesture, 67 bool user_gesture,
68 bool* was_blocked) override; 68 bool* was_blocked) override;
69 bool IsNeverVisible(content::WebContents* web_contents) override; 69 bool IsNeverVisible(content::WebContents* web_contents) override;
70 70
71 // content::WebContentsObserver implementation: 71 // content::WebContentsObserver implementation:
72 void RenderProcessGone(base::TerminationStatus status) override; 72 void RenderProcessGone(base::TerminationStatus status) override;
73 73
74 // content::NotificationObserver 74 // content::NotificationObserver
75 void Observe(int type, 75 void Observe(int type,
76 const content::NotificationSource& source, 76 const content::NotificationSource& source,
(...skipping 20 matching lines...) Expand all
97 BackgroundContents* contents; 97 BackgroundContents* contents;
98 98
99 // The name of the parent frame for these contents. 99 // The name of the parent frame for these contents.
100 const base::string16& frame_name; 100 const base::string16& frame_name;
101 101
102 // The ID of the parent application (if any). 102 // The ID of the parent application (if any).
103 const base::string16& application_id; 103 const base::string16& application_id;
104 }; 104 };
105 105
106 #endif // CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_ 106 #endif // CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/chrome_web_contents_delegate_android.cc ('k') | chrome/browser/background/background_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698