Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Side by Side Diff: chrome/browser/background/background_contents.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/background/background_contents.h" 5 #include "chrome/browser/background/background_contents.h"
6 6
7 #include "chrome/browser/background/background_contents_service.h" 7 #include "chrome/browser/background/background_contents_service.h"
8 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" 9 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 content::NotificationService::current()->Notify( 111 content::NotificationService::current()->Notify(
112 chrome::NOTIFICATION_BACKGROUND_CONTENTS_NAVIGATED, 112 chrome::NOTIFICATION_BACKGROUND_CONTENTS_NAVIGATED,
113 content::Source<Profile>(profile_), 113 content::Source<Profile>(profile_),
114 content::Details<BackgroundContents>(this)); 114 content::Details<BackgroundContents>(this));
115 } 115 }
116 116
117 // Forward requests to add a new WebContents to our delegate. 117 // Forward requests to add a new WebContents to our delegate.
118 void BackgroundContents::AddNewContents(WebContents* source, 118 void BackgroundContents::AddNewContents(WebContents* source,
119 WebContents* new_contents, 119 WebContents* new_contents,
120 WindowOpenDisposition disposition, 120 WindowOpenDisposition disposition,
121 const gfx::Rect& initial_pos, 121 const gfx::Rect& initial_rect,
122 bool user_gesture, 122 bool user_gesture,
123 bool* was_blocked) { 123 bool* was_blocked) {
124 delegate_->AddWebContents( 124 delegate_->AddWebContents(
125 new_contents, disposition, initial_pos, user_gesture, was_blocked); 125 new_contents, disposition, initial_rect, user_gesture, was_blocked);
126 } 126 }
127 127
128 bool BackgroundContents::IsNeverVisible(content::WebContents* web_contents) { 128 bool BackgroundContents::IsNeverVisible(content::WebContents* web_contents) {
129 DCHECK_EQ(extensions::VIEW_TYPE_BACKGROUND_CONTENTS, 129 DCHECK_EQ(extensions::VIEW_TYPE_BACKGROUND_CONTENTS,
130 extensions::GetViewType(web_contents)); 130 extensions::GetViewType(web_contents));
131 return true; 131 return true;
132 } 132 }
133 133
134 void BackgroundContents::RenderProcessGone(base::TerminationStatus status) { 134 void BackgroundContents::RenderProcessGone(base::TerminationStatus status) {
135 content::NotificationService::current()->Notify( 135 content::NotificationService::current()->Notify(
(...skipping 17 matching lines...) Expand all
153 case chrome::NOTIFICATION_PROFILE_DESTROYED: 153 case chrome::NOTIFICATION_PROFILE_DESTROYED:
154 case chrome::NOTIFICATION_APP_TERMINATING: { 154 case chrome::NOTIFICATION_APP_TERMINATING: {
155 delete this; 155 delete this;
156 break; 156 break;
157 } 157 }
158 default: 158 default:
159 NOTREACHED() << "Unexpected notification sent."; 159 NOTREACHED() << "Unexpected notification sent.";
160 break; 160 break;
161 } 161 }
162 } 162 }
OLDNEW
« no previous file with comments | « chrome/browser/background/background_contents.h ('k') | chrome/browser/background/background_contents_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698