Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 889383002: Initialize CompilationInfo::osr_expr_stack_height correctly. (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Initialize CompilationInfo::osr_expr_stack_height correctly. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/9df88454c0674ebcc808af513e196ec4b1f116a9 Cr-Commit-Position: refs/heads/master@{#26382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/compiler.cc View 6 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
titzer
5 years, 10 months ago (2015-02-02 13:32:10 UTC) #1
titzer
5 years, 10 months ago (2015-02-02 13:33:38 UTC) #3
marja
lgtm as in looks generally sane
5 years, 10 months ago (2015-02-02 13:34:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889383002/1
5 years, 10 months ago (2015-02-02 13:36:02 UTC) #6
Michael Starzinger
LGTM, it is always good to have six(!) copied of the constructor, just in case ...
5 years, 10 months ago (2015-02-02 13:43:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 14:30:05 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 14:30:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9df88454c0674ebcc808af513e196ec4b1f116a9
Cr-Commit-Position: refs/heads/master@{#26382}

Powered by Google App Engine
This is Rietveld 408576698