public/web/WebMenuItemInfo.h - Issue 889343002: Added a test for icon attribute values with leading/trailing spaces.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: public/web/WebMenuItemInfo.h

Issue 889343002: Added a test for icon attribute values with leading/trailing spaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added a comment to icon string Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 : type(Option)	51 : type(Option)

52 , action(0)	52 , action(0)

53 , textDirection(WebTextDirectionDefault)	53 , textDirection(WebTextDirectionDefault)

54 , hasTextDirectionOverride(false)	54 , hasTextDirectionOverride(false)

55 , enabled(false)	55 , enabled(false)

56 , checked(false)	56 , checked(false)

57 {	57 {

58 }	58 }

59	59

60 WebString label;	60 WebString label;

	61 // "icon" provides absolute URL of an image that repesents the command.

61 WebString icon;	62 WebString icon;

62 WebString toolTip;	63 WebString toolTip;

63 Type type;	64 Type type;

64 unsigned action;	65 unsigned action;

65 WebTextDirection textDirection;	66 WebTextDirection textDirection;

66 WebVector<WebMenuItemInfo> subMenuItems;	67 WebVector<WebMenuItemInfo> subMenuItems;

67 bool hasTextDirectionOverride;	68 bool hasTextDirectionOverride;

68 bool enabled;	69 bool enabled;

69 bool checked;	70 bool checked;

70 };	71 };

71	72

72 } // namespace blink	73 } // namespace blink

73	74

74 #endif	75 #endif

OLD	NEW

« no previous file with comments | « LayoutTests/http/tests/misc/custom-context-menu-expected.txt ('k') | no next file » | no next file with comments »