Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889303005: return reference to cache instead of copying the mask (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

return reference to cache instead of copying the mask BUG=437128 Committed: https://skia.googlesource.com/skia/+/b0df8be137d8fb49436e46d1fd1a5aec8b7ab562

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : reorder declarations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -45 lines) Patch
M include/core/SkMaskFilter.h View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M src/core/SkMask.cpp View 1 3 chunks +14 lines, -0 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 5 chunks +11 lines, -5 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 5 chunks +36 lines, -39 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889303005/1
5 years, 10 months ago (2015-02-04 04:46:05 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-04 04:46:06 UTC) #3
reed1
ptal
5 years, 10 months ago (2015-02-04 06:11:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889303005/20001
5 years, 10 months ago (2015-02-04 06:11:25 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-04 06:11:26 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 10 months ago (2015-02-04 12:11:26 UTC) #10
reed1
ptal
5 years, 10 months ago (2015-02-04 15:19:58 UTC) #12
robertphillips
lgtm + a nit https://codereview.chromium.org/889303005/diff/20001/include/core/SkMaskFilter.h File include/core/SkMaskFilter.h (right): https://codereview.chromium.org/889303005/diff/20001/include/core/SkMaskFilter.h#newcode18 include/core/SkMaskFilter.h:18: class GrContext; Shouldn't this guy ...
5 years, 10 months ago (2015-02-04 15:37:42 UTC) #13
reed1
https://codereview.chromium.org/889303005/diff/20001/include/core/SkMaskFilter.h File include/core/SkMaskFilter.h (right): https://codereview.chromium.org/889303005/diff/20001/include/core/SkMaskFilter.h#newcode18 include/core/SkMaskFilter.h:18: class GrContext; On 2015/02/04 15:37:42, robertphillips wrote: > Shouldn't ...
5 years, 10 months ago (2015-02-04 17:00:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889303005/40001
5 years, 10 months ago (2015-02-04 17:01:01 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 17:07:24 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b0df8be137d8fb49436e46d1fd1a5aec8b7ab562

Powered by Google App Engine
This is Rietveld 408576698