Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 8893018: Greedy searchbox focus fix (http://code.google.com/p/dart/issues/detail?id=749). (Closed)

Created:
9 years ago by pquitslund
Modified:
9 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Greedy searchbox focus fix (http://code.google.com/p/dart/issues/detail?id=749). The rub: we cache the previous focus control in the interest of restoring when a search is complete. In some cases, this cache was getting wrongly written to point at the search text field (breaking defocus). Committed: https://code.google.com/p/dart/source/detail?r=2352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/omni/OmniBoxControlContribution.java View 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pquitslund
9 years ago (2011-12-09 23:54:45 UTC) #1
messick
lgtm
9 years ago (2011-12-10 01:55:04 UTC) #2
danrubel
lgtm
9 years ago (2011-12-10 13:47:21 UTC) #3
devoncarew
9 years ago (2011-12-11 19:07:15 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698