Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 889253004: Add support for extensions_unittests to the GN build (Closed)

Created:
5 years, 10 months ago by James Cook
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for extensions_unittests to the GN build * Fix dependency issues in //extensions * Make protobuf library add the "src" directory to the compiler's include directory list, otherwise it tries to use /usr/include/google/protobuf which has incompatible headers. BUG=455919 TEST=compiles and links in both component and non-component builds Committed: https://crrev.com/f112ccdd476fc95addd79f7a120162d2f33c3473 Cr-Commit-Position: refs/heads/master@{#315067}

Patch Set 1 #

Patch Set 2 : fix browser_tests #

Patch Set 3 : (gn) rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -134 lines) Patch
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 1 2 3 chunks +144 lines, -126 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/vpn_provider/vpn_service_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/extensions.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/extensions_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/protobuf/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
James Cook
rockot, PTAL
5 years, 10 months ago (2015-02-05 23:08:20 UTC) #2
Ken Rockot(use gerrit already)
I am happy with all of this. All of this is good. Except for the ...
5 years, 10 months ago (2015-02-05 23:32:45 UTC) #3
Ken Rockot(use gerrit already)
On 2015/02/05 23:32:45, Ken Rockot wrote: > I am happy with all of this. All ...
5 years, 10 months ago (2015-02-05 23:33:33 UTC) #4
James Cook
rockot, please take another look (browser_tests was directly including cast_channel/test_util.cc)
5 years, 10 months ago (2015-02-06 00:52:57 UTC) #6
Ken Rockot(use gerrit already)
lgtm for reals
5 years, 10 months ago (2015-02-06 00:53:27 UTC) #7
James Cook
scottmg, can I get OWNERS for third_party/protobuf/BUILD.gn? Ken and I ran this by brettw and ...
5 years, 10 months ago (2015-02-06 00:58:36 UTC) #9
scottmg
On 2015/02/06 00:58:36, James Cook wrote: > scottmg, can I get OWNERS for third_party/protobuf/BUILD.gn? Ken ...
5 years, 10 months ago (2015-02-06 01:10:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889253004/10008
5 years, 10 months ago (2015-02-06 15:12:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/40996)
5 years, 10 months ago (2015-02-06 15:17:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889253004/30001
5 years, 10 months ago (2015-02-06 16:59:10 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 10 months ago (2015-02-06 18:06:42 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 18:07:14 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f112ccdd476fc95addd79f7a120162d2f33c3473
Cr-Commit-Position: refs/heads/master@{#315067}

Powered by Google App Engine
This is Rietveld 408576698