Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 889253003: Fix XFA build after combining PDFium into Chromium binary. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix XFA build after combining PDFium into Chromium binary. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/385729be5d146a2b0dc10cb7f5c1718316bcb253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -85 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M core/src/fxcodec/fx_lpng/lpng_v163/png.h View 1 chunk +88 lines, -85 lines 0 comments Download
M pdfium.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jam
admittedly hacky, but any better approaches welcomed!
5 years, 10 months ago (2015-02-05 22:31:26 UTC) #2
Tom Sepez
Works for me. LGTM.
5 years, 10 months ago (2015-02-05 22:59:50 UTC) #3
jam
5 years, 10 months ago (2015-02-06 23:51:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
385729be5d146a2b0dc10cb7f5c1718316bcb253 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698