Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/BUILD.gn

Issue 889203002: Disable more GN linking on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/blink/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index a40626c3fbde7cacf25a2306f54bb6e7be7a89f9..b7ecabd0607a903b7ccca64cea487e99c5801abb 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -217,61 +217,63 @@ group("all_components") {
# component (it's important to use a source_set instead of a static library or
# no tests will run) and add a reference here. You can add more than one unit
# test target if convenient.
-test("components_unittests") {
- sources = [
- "test/run_all_unittests.cc",
- ]
+if (!is_win || link_chrome_on_windows) {
+ test("components_unittests") {
+ sources = [
+ "test/run_all_unittests.cc",
+ ]
- # Add only ":unit_tests" dependencies here. If your tests have dependencies
- # (this would at least include the component itself), they should be on the
- # test source set and not here.
- deps = [
- "//components/auto_login_parser:unit_tests",
- "//components/autofill/content/browser:unit_tests",
- "//components/autofill/core/browser:unit_tests",
- "//components/autofill/core/common:unit_tests",
- "//components/bookmarks/browser:unit_tests",
- "//components/captive_portal:unit_tests",
- "//components/cloud_devices/common:unit_tests",
- "//components/content_settings/core/browser:unit_tests",
- "//components/content_settings/core/common:unit_tests",
- "//components/crx_file:unit_tests",
- "//components/data_reduction_proxy/core/browser:unit_tests",
- "//components/data_reduction_proxy/core/common:unit_tests",
- "//components/dom_distiller/core:unit_tests",
- "//components/domain_reliability:unit_tests",
- "//components/favicon_base:unit_tests",
- "//components/google/core/browser:unit_tests",
- "//components/invalidation:unittests",
- "//components/login:unit_tests",
- "//components/metrics:unit_tests",
- "//components/omnibox:unit_tests",
- "//components/ownership:unit_tests",
- "//components/packed_ct_ev_whitelist:unit_tests",
- "//components/proximity_auth:unit_tests",
- "//components/update_client:unit_tests",
- "//components/variations:unit_tests",
- "//components/web_resource:unit_tests",
- "//components/webdata/common:unit_tests",
+ # Add only ":unit_tests" dependencies here. If your tests have dependencies
+ # (this would at least include the component itself), they should be on the
+ # test source set and not here.
+ deps = [
+ "//components/auto_login_parser:unit_tests",
+ "//components/autofill/content/browser:unit_tests",
+ "//components/autofill/core/browser:unit_tests",
+ "//components/autofill/core/common:unit_tests",
+ "//components/bookmarks/browser:unit_tests",
+ "//components/captive_portal:unit_tests",
+ "//components/cloud_devices/common:unit_tests",
+ "//components/content_settings/core/browser:unit_tests",
+ "//components/content_settings/core/common:unit_tests",
+ "//components/crx_file:unit_tests",
+ "//components/data_reduction_proxy/core/browser:unit_tests",
+ "//components/data_reduction_proxy/core/common:unit_tests",
+ "//components/dom_distiller/core:unit_tests",
+ "//components/domain_reliability:unit_tests",
+ "//components/favicon_base:unit_tests",
+ "//components/google/core/browser:unit_tests",
+ "//components/invalidation:unittests",
+ "//components/login:unit_tests",
+ "//components/metrics:unit_tests",
+ "//components/omnibox:unit_tests",
+ "//components/ownership:unit_tests",
+ "//components/packed_ct_ev_whitelist:unit_tests",
+ "//components/proximity_auth:unit_tests",
+ "//components/update_client:unit_tests",
+ "//components/variations:unit_tests",
+ "//components/web_resource:unit_tests",
+ "//components/webdata/common:unit_tests",
- # These are the deps required by the code in this target.
- "//base",
- "//base/test:test_support",
- "//content/test:test_support",
- "//ui/base",
- ]
+ # These are the deps required by the code in this target.
+ "//base",
+ "//base/test:test_support",
+ "//content/test:test_support",
+ "//ui/base",
+ ]
- # TODO(GYP) need this target.
- #'breakpad/app/crash_keys_win_unittest.cc',
+ # TODO(GYP) need this target.
+ #'breakpad/app/crash_keys_win_unittest.cc',
- # Precache tests need these defines.
- #configs += [ "//components/precache/core:precache_config" ]
+ # Precache tests need these defines.
+ #configs += [ "//components/precache/core:precache_config" ]
- if (toolkit_views) {
- # TODO(GYP) enable this as above.
- #deps += [ "//components/constrained_window:unit_tests" ]
- }
- if (is_win) {
- deps += [ "//components/browser_watcher:unit_tests" ]
+ if (toolkit_views) {
+ # TODO(GYP) enable this as above.
+ #deps += [ "//components/constrained_window:unit_tests" ]
+ }
+ if (is_win) {
+ deps += [ "//components/browser_watcher:unit_tests" ]
+ }
}
}
« no previous file with comments | « cc/blink/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698