Initialize Android CrashDumpManager earlier

components/crash/browser/crash_dump_manager_android.cc

Index: components/crash/browser/crash_dump_manager_android.cc
diff --git a/components/crash/browser/crash_dump_manager_android.cc b/components/crash/browser/crash_dump_manager_android.cc
index 8ef0b7c58051ca91bf05b08a1d3f17512ee9dcd7..ee3afdd90af81cb05272dbe9476aea83f69e6b7d 100644
--- a/components/crash/browser/crash_dump_manager_android.cc
+++ b/components/crash/browser/crash_dump_manager_android.cc
@@ -29,13 +29,14 @@ CrashDumpManager* CrashDumpManager::instance_ = NULL;
 
 // static
 CrashDumpManager* CrashDumpManager::GetInstance() {
+  CHECK(instance_);
   return instance_;
 }
 
 CrashDumpManager::CrashDumpManager(const base::FilePath& crash_dump_dir)
     : crash_dump_dir_(crash_dump_dir) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  DCHECK(!instance_);
+  CHECK(!instance_);

[Lei Zhang, 2015/01/31 01:14:22]

I haven't looked very hard, but are you worried this code isn't getting
exercised enough as is because it's only executed in official builds without
DCHECKs?

[cjhopman, 2015/01/31 01:20:48]

Thinking about it a bit, I think this one could probably just stay a DCHECK, I'm
not really worried about us calling this twice.

I think I'd keep the two added CHECKs though so that if we have these crashes
again sometime, it'll be obvious that it's because this hasn't been initialized.

 
   instance_ = this;
 
@@ -83,6 +84,7 @@ base::File CrashDumpManager::CreateMinidumpFile(int child_process_id) {
 void CrashDumpManager::ProcessMinidump(const base::FilePath& minidump_path,
                                        base::ProcessHandle pid) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+  CHECK(instance_);
   int64 file_size = 0;
   int r = base::GetFileSize(minidump_path, &file_size);
   DCHECK(r) << "Failed to retrieve size for minidump "