Initialize Android CrashDumpManager earlier

chrome/browser/chrome_browser_main_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_android.h"
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/trace_event/trace_event.h"
 #include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"
@@ skipping 11 matching lines @@
 #include "ui/base/ui_base_paths.h"
 
 ChromeBrowserMainPartsAndroid::ChromeBrowserMainPartsAndroid(
     const content::MainFunctionParams& parameters)
     : ChromeBrowserMainParts(parameters) {
 }
 
 ChromeBrowserMainPartsAndroid::~ChromeBrowserMainPartsAndroid() {
 }
 
-void ChromeBrowserMainPartsAndroid::PreProfileInit() {
-  TRACE_EVENT0("startup", "ChromeBrowserMainPartsAndroid::PreProfileInit")
+int ChromeBrowserMainPartsAndroid::PreCreateThreads() {
+  TRACE_EVENT0("startup", "ChromeBrowserMainPartsAndroid::PreCreateThreads")
+
+  // The CrashDumpManager must be initialized before any child process is
+  // created (as they need to access it during creation). Such processes
+  // are created on the PROCESS_LAUNCHER thread, and so the manager is
+  // initialized before that thread is created.
 #if defined(GOOGLE_CHROME_BUILD)
   // TODO(jcivelli): we should not initialize the crash-reporter when it was not
   // enabled. Right now if it is disabled we still generate the minidumps but we
   // do not upload them.
   bool breakpad_enabled = true;
 #else
   bool breakpad_enabled = false;
 #endif
 
   // Allow Breakpad to be enabled in Chromium builds for testing purposes.
   if (!breakpad_enabled)
     breakpad_enabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
         switches::kEnableCrashReporterForTesting);
 
   if (breakpad_enabled) {
     base::FilePath crash_dump_dir;
     PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_dump_dir);
     crash_dump_manager_.reset(new breakpad::CrashDumpManager(crash_dump_dir));
   }
 
-  ChromeBrowserMainParts::PreProfileInit();
+  return ChromeBrowserMainParts::PreCreateThreads();
 }
 
 void ChromeBrowserMainPartsAndroid::PostProfileInit() {
   Profile* main_profile = profile();
   search_counter_.reset(new GoogleSearchCounterAndroid(main_profile));
   InitBookmarksExperimentState(main_profile);
 
   ChromeBrowserMainParts::PostProfileInit();
 }
 
@@ skipping 22 matching lines @@
       "ChromeBrowserMainPartsAndroid::PreEarlyInitialization:StartUiMsgLoop");
     base::MessageLoopForUI::current()->Start();
   }
 
   ChromeBrowserMainParts::PreEarlyInitialization();
 }
 
 void ChromeBrowserMainPartsAndroid::ShowMissingLocaleMessageBox() {
   NOTREACHED();
 }