DescriptionRevert of media: Enable Opus support in Clank <video> and MSE (patchset #5 id:100001 of https://codereview.chromium.org/866573004/)
Reason for revert:
This is breaking downstream builders on L:
C 1029.038s Main [FAIL] MediaCanPlayTypeTest.CodecSupportTest_webm:
C 1029.038s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1029.039s Main [WARNING:proxy_service.cc(898)] PAC support disabled because there is no system implementation
C 1029.039s Main ../../content/browser/media/media_canplaytype_browsertest.cc:278: Failure
C 1029.039s Main Value of: CanPlay("'video/webm; codecs=\"vp8, opus\"'")
C 1029.039s Main Actual: "probably"
C 1029.039s Main Expected: kOpusProbably
C 1029.039s Main Which is: ""
C 1029.039s Main ../../content/browser/media/media_canplaytype_browsertest.cc:279: Failure
C 1029.039s Main Value of: CanPlay("'video/webm; codecs=\"vp8.0, opus\"'")
C 1029.039s Main Actual: "probably"
C 1029.039s Main Expected: kOpusProbably
C 1029.039s Main Which is: ""
C 1029.039s Main ../../content/browser/media/media_canplaytype_browsertest.cc:285: Failure
C 1029.039s Main Value of: CanPlay("'video/webm; codecs=\"vp9, opus\"'")
C 1029.039s Main Actual: "probably"
C 1029.039s Main Expected: VP9AndOpusProbably
C 1029.039s Main Which is: ""
C 1029.039s Main ../../content/browser/media/media_canplaytype_browsertest.cc:287: Failure
C 1029.039s Main Value of: CanPlay("'video/webm; codecs=\"vp9.0, opus\"'")
C 1029.039s Main Actual: "probably"
C 1029.040s Main Expected: VP9AndOpusProbably
C 1029.040s Main Which is: ""
C 1029.040s Main ../../content/browser/media/media_canplaytype_browsertest.cc:296: Failure
C 1029.040s Main Value of: CanPlay("'audio/webm; codecs=\"opus\"'")
C 1029.040s Main Actual: "probably"
C 1029.040s Main Expected: kOpusProbably
C 1029.040s Main Which is: ""
C 1029.040s Main ../../content/browser/media/media_canplaytype_browsertest.cc:297: Failure
C 1029.040s Main Value of: CanPlay("'audio/webm; codecs=\"opus, vorbis\"'")
C 1029.040s Main Actual: "probably"
C 1029.040s Main Expected: kOpusProbably
C 1029.040s Main Which is: ""
Spoke with vigneshv@ and reverting for now is the best thing to do while a fix is prepared.
Original issue's description:
> media: Enable Opus support in Clank <video> and MSE
>
> Opus audio codec is supported by the android platform starting from Lollipop.
> This CL enables canPlayType() support for Opus on Clank and MSE playback of Opus
> in Clank. This brings Opus feature parity with Desktop Chromium.
>
> BUG=318436
>
> Committed: https://crrev.com/95fcf214b5a9ba718d53efbf509c9d92e2514e4f
> Cr-Commit-Position: refs/heads/master@{#313549}
TBR=tomfinegan@chromium.org,wolenetz@chromium.org,rsleevi@chromium.org,qinmin@chromium.org,jschuh@chromium.org,vigneshv@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=318436
Committed: https://crrev.com/2da6713c500967ea55df5da7e4266f0370cba9ab
Cr-Commit-Position: refs/heads/master@{#314034}
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (1 generated)
|