Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 889053003: Revert of media: Enable Opus support in Clank <video> and MSE (Closed)

Created:
5 years, 10 months ago by Ted C
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, fgalligan1, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Enable Opus support in Clank <video> and MSE (patchset #5 id:100001 of https://codereview.chromium.org/866573004/) Reason for revert: This is breaking downstream builders on L: C 1029.038s Main [FAIL] MediaCanPlayTypeTest.CodecSupportTest_webm: C 1029.038s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const C 1029.039s Main [WARNING:proxy_service.cc(898)] PAC support disabled because there is no system implementation C 1029.039s Main ../../content/browser/media/media_canplaytype_browsertest.cc:278: Failure C 1029.039s Main Value of: CanPlay("'video/webm; codecs=\"vp8, opus\"'") C 1029.039s Main Actual: "probably" C 1029.039s Main Expected: kOpusProbably C 1029.039s Main Which is: "" C 1029.039s Main ../../content/browser/media/media_canplaytype_browsertest.cc:279: Failure C 1029.039s Main Value of: CanPlay("'video/webm; codecs=\"vp8.0, opus\"'") C 1029.039s Main Actual: "probably" C 1029.039s Main Expected: kOpusProbably C 1029.039s Main Which is: "" C 1029.039s Main ../../content/browser/media/media_canplaytype_browsertest.cc:285: Failure C 1029.039s Main Value of: CanPlay("'video/webm; codecs=\"vp9, opus\"'") C 1029.039s Main Actual: "probably" C 1029.039s Main Expected: VP9AndOpusProbably C 1029.039s Main Which is: "" C 1029.039s Main ../../content/browser/media/media_canplaytype_browsertest.cc:287: Failure C 1029.039s Main Value of: CanPlay("'video/webm; codecs=\"vp9.0, opus\"'") C 1029.039s Main Actual: "probably" C 1029.040s Main Expected: VP9AndOpusProbably C 1029.040s Main Which is: "" C 1029.040s Main ../../content/browser/media/media_canplaytype_browsertest.cc:296: Failure C 1029.040s Main Value of: CanPlay("'audio/webm; codecs=\"opus\"'") C 1029.040s Main Actual: "probably" C 1029.040s Main Expected: kOpusProbably C 1029.040s Main Which is: "" C 1029.040s Main ../../content/browser/media/media_canplaytype_browsertest.cc:297: Failure C 1029.040s Main Value of: CanPlay("'audio/webm; codecs=\"opus, vorbis\"'") C 1029.040s Main Actual: "probably" C 1029.040s Main Expected: kOpusProbably C 1029.040s Main Which is: "" Spoke with vigneshv@ and reverting for now is the best thing to do while a fix is prepared. Original issue's description: > media: Enable Opus support in Clank <video> and MSE > > Opus audio codec is supported by the android platform starting from Lollipop. > This CL enables canPlayType() support for Opus on Clank and MSE playback of Opus > in Clank. This brings Opus feature parity with Desktop Chromium. > > BUG=318436 > > Committed: https://crrev.com/95fcf214b5a9ba718d53efbf509c9d92e2514e4f > Cr-Commit-Position: refs/heads/master@{#313549} TBR=tomfinegan@chromium.org,wolenetz@chromium.org,rsleevi@chromium.org,qinmin@chromium.org,jschuh@chromium.org,vigneshv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=318436 Committed: https://crrev.com/2da6713c500967ea55df5da7e4266f0370cba9ab Cr-Commit-Position: refs/heads/master@{#314034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -106 lines) Patch
M content/common/media/media_player_messages_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M media/base/android/audio_decoder_job.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/android/audio_decoder_job.cc View 2 chunks +1 line, -4 lines 0 comments Download
M media/base/android/demuxer_stream_player_params.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/android/demuxer_stream_player_params.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 chunk +0 lines, -5 lines 0 comments Download
M media/base/android/media_codec_bridge.h View 2 chunks +1 line, -3 lines 0 comments Download
M media/base/android/media_codec_bridge.cc View 7 chunks +4 lines, -43 lines 0 comments Download
M media/base/android/media_codec_bridge_unittest.cc View 3 chunks +4 lines, -29 lines 0 comments Download
M media/filters/stream_parser_factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/base/mime_util.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ted C
Created Revert of media: Enable Opus support in Clank <video> and MSE
5 years, 10 months ago (2015-01-30 23:59:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889053003/1
5 years, 10 months ago (2015-01-31 00:01:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-31 00:03:08 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-01-31 00:04:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2da6713c500967ea55df5da7e4266f0370cba9ab
Cr-Commit-Position: refs/heads/master@{#314034}

Powered by Google App Engine
This is Rietveld 408576698