Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 889043002: Fix LibjingleTransport to notify about route changes only when connected. (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@policy_init_me2me
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix LibjingleTransport to notify about route changes only when connected. Previously LibjingleTransport was emitting RouteChange notification even before connection is established. As result the reported results were incorrect and confusing. Specifically it was always reporting connection as direct first even if it ends up going through the relay. Committed: https://crrev.com/dfb5e220446194f22436e2434f198f76f350e5b8 Cr-Commit-Position: refs/heads/master@{#314221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -28 lines) Patch
M remoting/protocol/libjingle_transport_factory.cc View 4 chunks +41 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
5 years, 10 months ago (2015-01-30 23:48:19 UTC) #2
dcaiafa
lgtm
5 years, 10 months ago (2015-02-02 19:37:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889043002/1
5 years, 10 months ago (2015-02-02 19:43:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 00:24:28 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 00:25:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfb5e220446194f22436e2434f198f76f350e5b8
Cr-Commit-Position: refs/heads/master@{#314221}

Powered by Google App Engine
This is Rietveld 408576698