Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 889033002: Jump to UI thread for extension activity logging unconditionally. (Closed)

Created:
5 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Jump to UI thread for extension activity logging unconditionally. Always dispatch the extension activity logging IPCs to the UI thread instead of checking first as the check will always be true. Committed: https://crrev.com/c7ac8c2c060410db6c1bca90d0491cd4dd9d19a8 Cr-Commit-Position: refs/heads/master@{#314172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M chrome/browser/renderer_host/chrome_extension_message_filter.cc View 2 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Reilly Grant (use Gerrit)
Scott, please take a look at this cleanup patch.
5 years, 10 months ago (2015-01-31 01:08:40 UTC) #2
sky
Someone on the extensions team should review this.
5 years, 10 months ago (2015-02-02 15:44:06 UTC) #3
Reilly Grant (use Gerrit)
On 2015/02/02 15:44:06, sky wrote: > Someone on the extensions team should review this. Adding ...
5 years, 10 months ago (2015-02-02 16:45:49 UTC) #5
not at google - send to devlin
lgtm. Reilly it might be appropriate to add specific owners for this file in this ...
5 years, 10 months ago (2015-02-02 16:52:51 UTC) #6
sky
LGTM
5 years, 10 months ago (2015-02-02 17:19:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889033002/1
5 years, 10 months ago (2015-02-02 18:39:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 18:43:40 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 18:44:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7ac8c2c060410db6c1bca90d0491cd4dd9d19a8
Cr-Commit-Position: refs/heads/master@{#314172}

Powered by Google App Engine
This is Rietveld 408576698