Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 889013002: Android: Add strong binding for GPU process (Closed)

Created:
5 years, 10 months ago by no sievers
Modified:
5 years, 10 months ago
Reviewers:
Ted C, ppi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Put GPU process in foreground That makes browser, foreground renderer, and GPU have a similar priority. Otherwise the GPU process might drop behind other (even unrelated bg) processes and get killed too easily. BUG=448549, 453671 TBR=ppi@chromium.org Committed: https://crrev.com/e77a53958cc41a1df157929f492a52c564d37b1e Cr-Commit-Position: refs/heads/master@{#314173}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java View 5 chunks +9 lines, -4 lines 1 comment Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 8 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
no sievers
Ted, mind giving this a quick sanity check? ppi@ definitely needs to look at this ...
5 years, 10 months ago (2015-01-30 23:03:01 UTC) #3
Ted C
On 2015/01/30 23:03:01, sievers wrote: > Ted, mind giving this a quick sanity check? > ...
5 years, 10 months ago (2015-01-30 23:38:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889013002/1
5 years, 10 months ago (2015-01-31 02:23:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/3626)
5 years, 10 months ago (2015-01-31 09:21:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889013002/1
5 years, 10 months ago (2015-02-02 18:47:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 18:48:24 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e77a53958cc41a1df157929f492a52c564d37b1e Cr-Commit-Position: refs/heads/master@{#314173}
5 years, 10 months ago (2015-02-02 18:49:22 UTC) #12
ppi
Refactoring it at some point sounds good, I could imagine this becoming ChildProcessConnectionBase, ChildRendererProcessConnection and ...
5 years, 10 months ago (2015-02-03 14:29:11 UTC) #13
no sievers
5 years, 10 months ago (2015-02-04 21:37:24 UTC) #14
Message was sent while issue was closed.
On 2015/02/03 14:29:11, ppi wrote:
> Refactoring it at some point sounds good, I could imagine this becoming
> ChildProcessConnectionBase, ChildRendererProcessConnection and
> ChildGpuProcessConnection.
> 
> One comment below.
> 
>
https://codereview.chromium.org/889013002/diff/1/content/public/android/java/...
> File
>
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
> (right):
> 
>
https://codereview.chromium.org/889013002/diff/1/content/public/android/java/...
>
content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java:417:
> synchronized (mLock) {
> Should we put "assert !mAlwaysInForeground;" here too?
> 

Done in https://codereview.chromium.org/902593003

> BTW, are we going to use separate gpu process when running on Svelte?

No, I kept kInProcessGpu (at least for the time being) for those devices (see
content_startup_flags.cc) since we were worried about unexpected behavior wrt
Android's process management when under such memory constraints.

Powered by Google App Engine
This is Rietveld 408576698