Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 888993002: Add app with different channels to display_in_launcher/NTP api whitelist. (Closed)

Created:
5 years, 10 months ago by skare_
Modified:
5 years, 10 months ago
Reviewers:
robliao, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add app with different channels to display_in_launcher/NTP api whitelist BUG=453955 Committed: https://crrev.com/c7569a39d30b01d7585fb309754382e1c48eb067 Cr-Commit-Position: refs/heads/master@{#314029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/common/extensions/api/_manifest_features.json View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
skare_
5 years, 10 months ago (2015-01-30 22:01:35 UTC) #2
skare_
+yoz@ for OWNERS (chrome/common/extensions/api/OWNERS => chrome/common/extensions/OWNERS pointer)
5 years, 10 months ago (2015-01-30 22:10:15 UTC) #4
Yoyo Zhou
LGTM
5 years, 10 months ago (2015-01-30 22:15:59 UTC) #5
robliao
lgtm
5 years, 10 months ago (2015-01-30 22:18:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888993002/1
5 years, 10 months ago (2015-01-30 22:55:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 23:43:37 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 23:44:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7569a39d30b01d7585fb309754382e1c48eb067
Cr-Commit-Position: refs/heads/master@{#314029}

Powered by Google App Engine
This is Rietveld 408576698