Issue 888983003: Remove last dependency of HistoryService on //content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 888983003: Remove last dependency of HistoryService on //content (Closed)

Created:
5 years, 10 months ago by sdefresne

Modified:
5 years, 10 months ago

Reviewers:
droger

CC:
browser-components-watch_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@visitedlink

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove last dependency of HistoryService on //content Introduce a local typedef for the DownloadIdCallback type since it is really simple. Remove obsolete #includes. BUG=453790 Committed: https://crrev.com/2d6463e4820c51c9852e276c4690db0ae8350f30 Cr-Commit-Position: refs/heads/master@{#314570}

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
M	chrome/browser/history/android/android_provider_backend.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/history/android/bookmark_model_sql_handler.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/history/history_service.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/history/history_service.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888983003/20001

5 years, 10 months ago (2015-02-04 15:17:41 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-04 16:17:51 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/2d6463e4820c51c9852e276c4690db0ae8350f30
Cr-Commit-Position: refs/heads/master@{#314570}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages