Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 888913002: Manage profiles in BluetoothAdapter on ChromeOS (Closed)

Created:
5 years, 10 months ago by Marie Janssen
Modified:
5 years, 10 months ago
Reviewers:
keybuk, armansito
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manage profiles in BluetoothAdapter on ChromeOS Profiles in bluez are not specific to a device. When client code tries to connect to two different devices, only one profile is created, managed by BluetoothAdapterChromeOS. dbus messages are multiplexed based on the device desired using new class BluetoothAdapterProfileChromeOS. This is a resubmit with bugfixes after https://codereview.chromium.org/851123002/ was reverted by https://codereview.chromium.org/868753006/ BUG=421207 Committed: https://crrev.com/f3f0784e90e8d4a26b1aa3d57e435a01b44a99a2 Cr-Commit-Position: refs/heads/master@{#314030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+842 lines, -166 lines) Patch
M chromeos/dbus/fake_bluetooth_profile_manager_client.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_profile_service_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.h View 7 chunks +45 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.cc View 2 chunks +71 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_adapter_profile_chromeos.h View 1 chunk +101 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_adapter_profile_chromeos.cc View 1 chunk +165 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc View 1 chunk +297 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 1 chunk +3 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos.h View 6 chunks +14 lines, -21 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos.cc View 17 chunks +112 lines, -138 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos_unittest.cc View 13 chunks +24 lines, -5 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
armansito
lgtm
5 years, 10 months ago (2015-01-30 22:13:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888913002/1
5 years, 10 months ago (2015-01-30 22:14:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 23:51:07 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 23:51:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3f0784e90e8d4a26b1aa3d57e435a01b44a99a2
Cr-Commit-Position: refs/heads/master@{#314030}

Powered by Google App Engine
This is Rietveld 408576698