Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/test/nacl/nacl_browsertest_util.cc

Issue 888903004: Non-SFI mode:Suid sandbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add --disable-namespace-sandbox flag to browser tests temporarily. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/nacl/nacl_browsertest_util.cc
diff --git a/chrome/test/nacl/nacl_browsertest_util.cc b/chrome/test/nacl/nacl_browsertest_util.cc
index 6248d8a776212a439f7c70c2f89d1eab7f43b32b..01084d64a28e12d6f85153d7e3fffc84e1e9cfd9 100644
--- a/chrome/test/nacl/nacl_browsertest_util.cc
+++ b/chrome/test/nacl/nacl_browsertest_util.cc
@@ -297,6 +297,8 @@ void NaClBrowserTestTransitionalNonSfi::SetUpCommandLine(
base::CommandLine* command_line) {
NaClBrowserTestNonSfiMode::SetUpCommandLine(command_line);
command_line->AppendSwitch(switches::kUseNaClHelperNonSfi);
+ // TODO(hidehiko): Remove this flag, when namespace sandbox is supported.
Mark Seaborn 2015/03/04 19:32:50 "...supported by nacl_helper_nonsfi"? (Same below
hidehiko 2015/03/05 05:26:53 Done.
+ command_line->AppendSwitch(switches::kDisableNamespaceSandbox);
}
base::FilePath::StringType NaClBrowserTestStatic::Variant() {
@@ -322,6 +324,8 @@ void NaClBrowserTestPnaclTransitionalNonSfi::SetUpCommandLine(
base::CommandLine* command_line) {
NaClBrowserTestPnaclNonSfi::SetUpCommandLine(command_line);
command_line->AppendSwitch(switches::kUseNaClHelperNonSfi);
+ // TODO(hidehiko): Remove this flag, when namespace sandbox is supported.
+ command_line->AppendSwitch(switches::kDisableNamespaceSandbox);
}
void NaClBrowserTestNewlibExtension::SetUpCommandLine(
« no previous file with comments | « no previous file | chrome/test/ppapi/ppapi_browsertest.cc » ('j') | components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698