Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 888873003: tools/sort_sources.py: sort C++ source file names in build files. (Closed)

Created:
5 years, 10 months ago by satorux1
Modified:
5 years, 10 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/sort_sources.py: sort C++ source file names in build files. tools/git/move_source_file.py updates C++ source file names in build files for you, but it does not sort the updated file names. With this tool, you can sort C++ source file names in build files (both GYP and GN files supported) automatically. It's not perfect but should work reasonably well. BUG=456014 TEST=Run the tool against some build files. The results are included in the patch. Committed: https://crrev.com/3d23ca0518139be109b6d52a8bf01b55c7ca29e3 Cr-Commit-Position: refs/heads/master@{#315517}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -61 lines) Patch
M chrome/chrome_browser_chromeos.gypi View 9 chunks +21 lines, -21 lines 0 comments Download
M chromeos/chromeos.gyp View 5 chunks +9 lines, -9 lines 0 comments Download
M google_apis/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M google_apis/google_apis.gyp View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/sort-headers.py View 1 chunk +1 line, -22 lines 0 comments Download
A tools/sort_sources.py View 1 1 chunk +93 lines, -0 lines 0 comments Download
A tools/yes_no.py View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
satorux1
5 years, 10 months ago (2015-02-09 08:13:35 UTC) #2
Daniel Erat
lgtm https://codereview.chromium.org/888873003/diff/1/tools/sort_sources.py File tools/sort_sources.py (right): https://codereview.chromium.org/888873003/diff/1/tools/sort_sources.py#newcode2 tools/sort_sources.py:2: # Copyright 2014 The Chromium Authors. All rights ...
5 years, 10 months ago (2015-02-09 16:30:02 UTC) #3
satorux1
https://codereview.chromium.org/888873003/diff/1/tools/sort_sources.py File tools/sort_sources.py (right): https://codereview.chromium.org/888873003/diff/1/tools/sort_sources.py#newcode2 tools/sort_sources.py:2: # Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 10 months ago (2015-02-10 06:55:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888873003/20001
5 years, 10 months ago (2015-02-10 06:56:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-10 08:05:02 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 08:05:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d23ca0518139be109b6d52a8bf01b55c7ca29e3
Cr-Commit-Position: refs/heads/master@{#315517}

Powered by Google App Engine
This is Rietveld 408576698