Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 888863002: Clean up some random includes in core/svg/ and core/rendering/svg/ (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up some random includes in core/svg/ and core/rendering/svg/ Mostly dropping unused headers. Use a more specific include in SVGGradientElement.cpp. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M Source/core/rendering/svg/RenderSVGContainer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
PTAL
5 years, 10 months ago (2015-01-30 13:54:12 UTC) #2
Erik Dahlström (inactive)
LGTM assuming the bots are happy.
5 years, 10 months ago (2015-01-30 14:06:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888863002/1
5 years, 10 months ago (2015-01-30 15:11:09 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 16:54:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189266

Powered by Google App Engine
This is Rietveld 408576698