Closing a guest session clears all browsing history.

chrome/browser/browsing_data/browsing_data_remover.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 
 #include <map>
 #include <set>
 #include <string>
 
@@ skipping 629 matching lines @@
 
     // Tell the shader disk cache to clear.
     content::RecordAction(UserMetricsAction("ClearBrowsingData_ShaderCache"));
     storage_partition_remove_mask |=
         content::StoragePartition::REMOVE_DATA_MASK_SHADER_CACHE;
 
     storage_partition_remove_mask |=
         content::StoragePartition::REMOVE_DATA_MASK_WEBRTC_IDENTITY;
 
 #if defined(ENABLE_EXTENSIONS)
-    // Clear the ephemeral apps cache.
-    EphemeralAppService::Get(profile_)->ClearCachedApps();
+    // Clear the ephemeral apps cache. This is NULL while testing.
+    if (EphemeralAppService::Get(profile_))

[Peter Kasting, 2015/02/10 21:43:36]

Get() is named as if it's expensive, implying we should use a temporary here
(or, if this isn't expensive, consider renaming to get()).

[Mike Lerman, 2015/02/10 21:53:32]

It's a BrowserContextKeyedService, which follows the pattern of having a static
Get(Profile*) method. (It's an expensive transaction to access a BCKS that
exists, nor to check if one exists).

[Peter Kasting, 2015/02/10 21:58:10]

Did you mean to say, it's NOT an expensive transaction?

I might just use a temp here anyway to avoid giving the reader any pause.

[Mike Lerman, 2015/02/11 15:15:32]

I did mean to say in-expensive. Serves me right for dashing out responses
quickly before I head out the door.
Ok, temp created.

+      EphemeralAppService::Get(profile_)->ClearCachedApps();
 #endif
   }
 
   if (storage_partition_remove_mask) {
     waiting_for_clear_storage_partition_data_ = true;
 
     content::StoragePartition* storage_partition;
     if (storage_partition_for_testing_)
       storage_partition = storage_partition_for_testing_;
     else
@@ skipping 558 matching lines @@
   waiting_for_clear_domain_reliability_monitor_ = false;
   NotifyAndDeleteIfDone();
 }
 
 // static
 BrowsingDataRemover::CallbackSubscription
     BrowsingDataRemover::RegisterOnBrowsingDataRemovedCallback(
         const BrowsingDataRemover::Callback& callback) {
   return GetOnBrowsingDataRemovedCallbacks()->Add(callback);
 }