Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 8888040: Merge r10215 from the bleeding_edge to the 3.7 branch. (Closed)

Created:
9 years ago by Vyacheslav Egorov (Chromium)
Modified:
9 years ago
CC:
v8-dev
Visibility:
Public.

Description

Merge r10215 from the bleeding_edge to the 3.7 branch. Ensure that non-optimized code objects are not flushed for inlined functions. Collector was flushing them if optimized code was reachable only through the stack (not through the JSFunction object) which happens when you have a pending lazy deoptimization. Also prevent v8::Script::New from leaking internal objects allocated by the compiler into outer HandleScope. R=kmillikin@chromium.org BUG=http://crbug.com/97116 TEST=test/mjsunit/regress/regress-97116.js Review URL: http://codereview.chromium.org/8888011 ------------------------------------------------------------------------ Committed: http://code.google.com/p/v8/source/detail?r=10222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -82 lines) Patch
M src/api.cc View 2 chunks +32 lines, -25 lines 0 comments Download
M src/mark-compact.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 14 chunks +70 lines, -51 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/v8threads.h View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-97116.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years ago (2011-12-09 11:13:09 UTC) #1
Kevin Millikin (Chromium)
9 years ago (2011-12-09 11:56:52 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698