Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: test/mjsunit/regress/regress-1015.js

Issue 8888006: Make more JS files beter match the coding standard. Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/regexp-static.js ('k') | test/mjsunit/regress/regress-1030466.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 13 matching lines...) Expand all
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // See: http://code.google.com/p/v8/issues/detail?id=1015 28 // See: http://code.google.com/p/v8/issues/detail?id=1015
29 29
30 // Object and array literals should be created using DefineOwnProperty, and 30 // Object and array literals should be created using DefineOwnProperty, and
31 // therefore not hit setters in the prototype. 31 // therefore not hit setters in the prototype.
32 32
33 function mkFail(message) { 33 function mkFail(message) {
34 return function () { assertUnreachable(message); } 34 return function () { assertUnreachable(message); };
35 } 35 }
36 36
37 Object.defineProperty(Object.prototype, "foo", 37 Object.defineProperty(Object.prototype, "foo",
38 {get: mkFail("oget"), set: mkFail("oset")}); 38 {get: mkFail("oget"), set: mkFail("oset")});
39 Object.defineProperty(Array.prototype, "2", 39 Object.defineProperty(Array.prototype, "2",
40 {get: mkFail("aget"), set: mkFail("aset")}); 40 {get: mkFail("aget"), set: mkFail("aset")});
41 41
42 function inFunction() { 42 function inFunction() {
43 for (var i = 0; i < 10; i++) { 43 for (var i = 0; i < 10; i++) {
44 // in loop. 44 // in loop.
45 var ja = JSON.parse('[1,2,3,4]'); 45 var ja = JSON.parse('[1,2,3,4]');
46 var jo = JSON.parse('{"bar": 10, "foo": 20}') 46 var jo = JSON.parse('{"bar": 10, "foo": 20}');
47 var jop = JSON.parse('{"bar": 10, "__proto__": { }, "foo": 20}') 47 var jop = JSON.parse('{"bar": 10, "__proto__": { }, "foo": 20}');
48 var a = [1,2,3,4]; 48 var a = [1,2,3,4];
49 var o = { bar: 10, foo: 20 }; 49 var o = { bar: 10, foo: 20 };
50 var op = { __proto__: { set bar(v) { assertUnreachable("bset"); } }, 50 var op = { __proto__: { set bar(v) { assertUnreachable("bset"); } },
51 bar: 10 }; 51 bar: 10 };
52 } 52 }
53 } 53 }
54 54
55 for (var i = 0; i < 10; i++) { 55 for (var i = 0; i < 10; i++) {
56 // In global scope. 56 // In global scope.
57 var ja = JSON.parse('[1,2,3,4]'); 57 var ja = JSON.parse('[1,2,3,4]');
58 var jo = JSON.parse('{"bar": 10, "foo": 20}') 58 var jo = JSON.parse('{"bar": 10, "foo": 20}');
59 var jop = JSON.parse('{"bar": 10, "__proto__": { }, "foo": 20}') 59 var jop = JSON.parse('{"bar": 10, "__proto__": { }, "foo": 20}');
60 var a = [1,2,3,4]; 60 var a = [1,2,3,4];
61 var o = { bar: 10, foo: 20 }; 61 var o = { bar: 10, foo: 20 };
62 var op = { __proto__: { set bar(v) { assertUnreachable("bset"); } }, 62 var op = { __proto__: { set bar(v) { assertUnreachable("bset"); } },
63 bar: 10 }; 63 bar: 10 };
64 // In function scope. 64 // In function scope.
65 inFunction(); 65 inFunction();
66 } 66 }
OLDNEW
« no previous file with comments | « test/mjsunit/regexp-static.js ('k') | test/mjsunit/regress/regress-1030466.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698