Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: test/mjsunit/mirror-array.js

Issue 8888006: Make more JS files beter match the coding standard. Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/megamorphic-callbacks.js ('k') | test/mjsunit/mirror-error.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 20 matching lines...) Expand all
31 function MirrorRefCache(json_refs) { 31 function MirrorRefCache(json_refs) {
32 var tmp = eval('(' + json_refs + ')'); 32 var tmp = eval('(' + json_refs + ')');
33 this.refs_ = []; 33 this.refs_ = [];
34 for (var i = 0; i < tmp.length; i++) { 34 for (var i = 0; i < tmp.length; i++) {
35 this.refs_[tmp[i].handle] = tmp[i]; 35 this.refs_[tmp[i].handle] = tmp[i];
36 } 36 }
37 } 37 }
38 38
39 MirrorRefCache.prototype.lookup = function(handle) { 39 MirrorRefCache.prototype.lookup = function(handle) {
40 return this.refs_[handle]; 40 return this.refs_[handle];
41 } 41 };
42 42
43 function testArrayMirror(a, names) { 43 function testArrayMirror(a, names) {
44 // Create mirror and JSON representation. 44 // Create mirror and JSON representation.
45 var mirror = debug.MakeMirror(a); 45 var mirror = debug.MakeMirror(a);
46 var serializer = debug.MakeMirrorSerializer(); 46 var serializer = debug.MakeMirrorSerializer();
47 var json = JSON.stringify(serializer.serializeValue(mirror)); 47 var json = JSON.stringify(serializer.serializeValue(mirror));
48 var refs = new MirrorRefCache( 48 var refs = new MirrorRefCache(
49 JSON.stringify(serializer.serializeReferencedObjects())); 49 JSON.stringify(serializer.serializeReferencedObjects()));
50 50
51 // Check the mirror hierachy. 51 // Check the mirror hierachy.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 106
107 // Check that the serialization contains all names properties. 107 // Check that the serialization contains all names properties.
108 if (names) { 108 if (names) {
109 for (var i = 0; i < names.length; i++) { 109 for (var i = 0; i < names.length; i++) {
110 var found = false; 110 var found = false;
111 for (var j = 0; j < fromJSON.properties.length; j++) { 111 for (var j = 0; j < fromJSON.properties.length; j++) {
112 if (names[i] == fromJSON.properties[j].name) { 112 if (names[i] == fromJSON.properties[j].name) {
113 found = true; 113 found = true;
114 } 114 }
115 } 115 }
116 assertTrue(found, names[i]) 116 assertTrue(found, names[i]);
117 } 117 }
118 } 118 }
119 } 119 }
120 120
121 121
122 // Test a number of different arrays. 122 // Test a number of different arrays.
123 testArrayMirror([]); 123 testArrayMirror([]);
124 testArrayMirror([1]); 124 testArrayMirror([1]);
125 testArrayMirror([1,2]); 125 testArrayMirror([1,2]);
126 testArrayMirror(["a", function(){}, [1,2], 2, /[ab]/]); 126 testArrayMirror(["a", function(){}, [1,2], 2, /[ab]/]);
127 127
128 a=[1]; 128 a=[1];
129 a[100]=7; 129 a[100]=7;
130 testArrayMirror(a); 130 testArrayMirror(a);
131 131
132 a=[1,2,3]; 132 a=[1,2,3];
133 a.x=2.2; 133 a.x=2.2;
134 a.y=function(){return null;} 134 a.y=function(){return null;};
135 testArrayMirror(a, ['x','y']); 135 testArrayMirror(a, ['x','y']);
136 136
137 var a = []; a.push(a); 137 var a = []; a.push(a);
138 testArrayMirror(a); 138 testArrayMirror(a);
OLDNEW
« no previous file with comments | « test/mjsunit/megamorphic-callbacks.js ('k') | test/mjsunit/mirror-error.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698