Make content_browsertests for Chrome on Android running with valid Views

content/browser/renderer_host/input/touch_input_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "content/browser/gpu/compositor_util.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/input/synthetic_web_input_event_builders.h"
 #include "content/common/input_messages.h"
 #include "content/public/browser/browser_message_filter.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/content_browser_test.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/shell/browser/shell.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "ui/events/event_switches.h"
 #include "ui/events/latency_info.h"
 
+#if defined(OS_ANDROID)
+#include "content/browser/renderer_host/render_widget_host_view_android.h"
+#endif
+
 using blink::WebInputEvent;
 
 namespace {
 
 void GiveItSomeTime() {
   base::RunLoop run_loop;
   base::MessageLoop::current()->PostDelayedTask(
       FROM_HERE,
       run_loop.QuitClosure(),
       base::TimeDelta::FromMilliseconds(10));
@@ skipping 108 matching lines @@
 
  protected:
   void LoadURLAndAddFilter() {
     const GURL data_url(kTouchEventDataURL);
     NavigateToURL(shell(), data_url);
 
     WebContentsImpl* web_contents =
         static_cast<WebContentsImpl*>(shell()->web_contents());
     RenderWidgetHostImpl* host =
         RenderWidgetHostImpl::From(web_contents->GetRenderViewHost());
+#if defined(OS_ANDROID)
+    static_cast<RenderWidgetHostViewAndroid*>(host->GetView())
+        ->GenerateNewFrameForTesting();

[no sievers, 2015/02/09 23:11:20]

Why do we need to do this, i.e. fake onSizeChanged()?

[Jaekyun Seok (inactive), 2015/02/09 23:23:14]

RenderWidgetHostImpl::OnUpdateRect() wasn't called at all without this. Actually
I don't understand deeply how ViewHostMsg_UpdateRect is generated.
Is there any other proper way?

+#else
     host->GetView()->SetSize(gfx::Size(400, 400));
+#endif
 
     // The page is loaded in the renderer, wait for a new frame to arrive.
     while (!host->ScheduleComposite())
       GiveItSomeTime();
 
     filter_ = new InputEventMessageFilter();
     host->GetProcess()->AddFilter(filter_.get());
   }
 
   void SetUpCommandLine(base::CommandLine* cmd) override {
     cmd->AppendSwitchASCII(switches::kTouchEvents,
                            switches::kTouchEventsEnabled);
   }
 
+#if defined(OS_ANDROID)
+  float GetPageScaleFactor() {
+    WebContentsImpl* web_contents =
+        static_cast<WebContentsImpl*>(shell()->web_contents());
+    RenderWidgetHostImpl* host =
+        RenderWidgetHostImpl::From(web_contents->GetRenderViewHost());
+    return static_cast<RenderWidgetHostViewAndroid*>(host->GetView())
+        ->last_page_scale_factor();
+  }
+#endif
+
   scoped_refptr<InputEventMessageFilter> filter_;
 };
 
 #if defined(OS_MACOSX)
 // TODO(ccameron): Failing on mac: crbug.com/346363
 #define MAYBE_TouchNoHandler DISABLED_TouchNoHandler
 #else
 #define MAYBE_TouchNoHandler TouchNoHandler
 #endif
 IN_PROC_BROWSER_TEST_F(TouchInputBrowserTest, MAYBE_TouchNoHandler) {
   LoadURLAndAddFilter();
   SyntheticWebTouchEvent touch;
 
   // A press on |first| should be acked with NO_CONSUMER_EXISTS since there is
   // no touch-handler on it.
+#if defined(OS_ANDROID)
+  float scale = GetPageScaleFactor();
+  touch.PressPoint(25 * scale, 25 * scale);
+#else
   touch.PressPoint(25, 25);
+#endif
   GetWidgetHost()->ForwardTouchEventWithLatencyInfo(touch, ui::LatencyInfo());
   filter()->WaitForAck(WebInputEvent::TouchStart);
 
   EXPECT_EQ(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS,
             filter()->last_ack_state());
 
   // If a touch-press is acked with NO_CONSUMER_EXISTS, then subsequent
   // touch-points don't need to be dispatched until the touch point is released.
   touch.ReleasePoint(0);
   GetWidgetHost()->ForwardTouchEventWithLatencyInfo(touch, ui::LatencyInfo());
   touch.ResetPoints();
 }
 
 IN_PROC_BROWSER_TEST_F(TouchInputBrowserTest, TouchHandlerNoConsume) {
   LoadURLAndAddFilter();
   SyntheticWebTouchEvent touch;
 
   // Press on |second| should be acked with NOT_CONSUMED since there is a
   // touch-handler on |second|, but it doesn't consume the event.
+#if defined(OS_ANDROID)
+  float scale = GetPageScaleFactor();
+  touch.PressPoint(125 * scale, 25 * scale);
+#else
   touch.PressPoint(125, 25);
+#endif
   GetWidgetHost()->ForwardTouchEventWithLatencyInfo(touch, ui::LatencyInfo());
   filter()->WaitForAck(WebInputEvent::TouchStart);
   EXPECT_EQ(INPUT_EVENT_ACK_STATE_NOT_CONSUMED, filter()->last_ack_state());
 
   touch.ReleasePoint(0);
   GetWidgetHost()->ForwardTouchEventWithLatencyInfo(touch, ui::LatencyInfo());
   filter()->WaitForAck(WebInputEvent::TouchEnd);
   touch.ResetPoints();
 }
 
 IN_PROC_BROWSER_TEST_F(TouchInputBrowserTest, TouchHandlerConsume) {
   LoadURLAndAddFilter();
   SyntheticWebTouchEvent touch;
 
   // Press on |third| should be acked with CONSUMED since the touch-handler on
   // |third| consimes the event.
+#if defined(OS_ANDROID)
+  float scale = GetPageScaleFactor();
+  touch.PressPoint(25 * scale, 125 * scale);
+#else
   touch.PressPoint(25, 125);
+#endif
   GetWidgetHost()->ForwardTouchEventWithLatencyInfo(touch, ui::LatencyInfo());
   filter()->WaitForAck(WebInputEvent::TouchStart);
   EXPECT_EQ(INPUT_EVENT_ACK_STATE_CONSUMED, filter()->last_ack_state());
 
   touch.ReleasePoint(0);
   GetWidgetHost()->ForwardTouchEventWithLatencyInfo(touch, ui::LatencyInfo());
   filter()->WaitForAck(WebInputEvent::TouchEnd);
 }
 
 #if defined(OS_MACOSX)
 // TODO(ccameron): Failing on mac: crbug.com/346363
 #define MAYBE_MultiPointTouchPress DISABLED_MultiPointTouchPress
 #else
 #define MAYBE_MultiPointTouchPress MultiPointTouchPress
 #endif
 IN_PROC_BROWSER_TEST_F(TouchInputBrowserTest, MAYBE_MultiPointTouchPress) {
   LoadURLAndAddFilter();
   SyntheticWebTouchEvent touch;
 
   // Press on |first|, which sould be acked with NO_CONSUMER_EXISTS. Then press
   // on |third|. That point should be acked with CONSUMED.
+#if defined(OS_ANDROID)
+  float scale = GetPageScaleFactor();
+  touch.PressPoint(25 * scale, 25 * scale);
+#else
   touch.PressPoint(25, 25);
+#endif
   GetWidgetHost()->ForwardTouchEventWithLatencyInfo(touch, ui::LatencyInfo());
   filter()->WaitForAck(WebInputEvent::TouchStart);
   EXPECT_EQ(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS,
             filter()->last_ack_state());
 
+#if defined(OS_ANDROID)
+  touch.PressPoint(25 * scale, 125 * scale);
+#else
   touch.PressPoint(25, 125);
+#endif
   GetWidgetHost()->ForwardTouchEventWithLatencyInfo(touch, ui::LatencyInfo());
   filter()->WaitForAck(WebInputEvent::TouchStart);
   EXPECT_EQ(INPUT_EVENT_ACK_STATE_CONSUMED, filter()->last_ack_state());
 }
 
 }  // namespace content