Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 888783003: win/swarming: Make 64-bit component builds work on swarming. (Closed)

Created:
5 years, 10 months ago by Nico
Modified:
5 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win/swarming: Make 64-bit component builds work on swarming. Fun fact: Neither main nor try waterfalls test this configuration yet. Only our poor clang/win fyi bots ran into this. BUG=453657 R=maruel@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c4893d87299560b1e899eba67c64f07cdcb0fe82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/base.isolate View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 10 months ago (2015-01-30 01:03:37 UTC) #2
M-A Ruel
lgtm
5 years, 10 months ago (2015-01-30 01:04:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888783003/1
5 years, 10 months ago (2015-01-30 01:05:59 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4893d87299560b1e899eba67c64f07cdcb0fe82 Cr-Commit-Position: refs/heads/master@{#313853}
5 years, 10 months ago (2015-01-30 01:32:31 UTC) #6
Nico
5 years, 10 months ago (2015-01-30 01:32:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4893d87299560b1e899eba67c64f07cdcb0fe82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698