Composite to cc::Display from ui::InProcessContextFactory.

Composite to cc::Display from ui::InProcessContextFactory.

The trees this composites may contain SurfaceLayers, so they have to be aggregated into a Display before being drawn. Also move OnscreenDisplayClient and SurfaceDisplayOutputSurface into cc/surfaces/ so they can be used by ui/compositor.

Committed: https://crrev.com/f400ce53d5f5dfe57d0f533ae1b86e19c7ad72c6
Cr-Commit-Position: refs/heads/master@{#314269}

[jbauman, 2015-01-30 02:03:31]

jbauman@chromium.org changed reviewers:
+ jamesr@chromium.org, piman@chromium.org

[piman, 2015-01-30 04:02:34]

lgtm

[piman, 2015-01-30 04:03:49]

nit: the issue title mentions NoTransportImageTransportFactory, but this is
really about InProcessContextFactory, can you fix?

On Thu, Jan 29, 2015 at 8:02 PM, <piman@chromium.org> wrote:

> lgtm
>
>
>
> https://codereview.chromium.org/888783002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jamesr, 2015-01-30 20:33:10]

lgtm

https://codereview.chromium.org/888783002/diff/1/cc/surfaces/display_client.h
File cc/surfaces/display_client.h (right):

https://codereview.chromium.org/888783002/diff/1/cc/surfaces/display_client.h...
cc/surfaces/display_client.h:16: class CC_SURFACES_EXPORT DisplayClient {
this type has no exported fields, just a vtable, so you don't need CC_EXPORT

[jbauman, 2015-01-30 23:09:13]

jbauman@chromium.org changed reviewers:
+ sadrul@chormium.org

[jbauman, 2015-01-30 23:09:14]

Also adding sadrul@ for OWNERS review of ui/.

[jbauman, 2015-02-03 00:08:18]

jbauman@chromium.org changed reviewers:
+ sky@chromium.org
- sadrul@chormium.org

[jbauman, 2015-02-03 00:08:19]

I guess sadrul@ is ooo, so sky@ could you do a ui/ OWNERS review?

[sky, 2015-02-03 00:44:58]

https://codereview.chromium.org/888783002/diff/20001/ui/compositor/test/in_pr...
File ui/compositor/test/in_process_context_factory.cc (right):

https://codereview.chromium.org/888783002/diff/20001/ui/compositor/test/in_pr...
ui/compositor/test/in_process_context_factory.cc:90:
InProcessContextFactory::~InProcessContextFactory() {}
Might per_compositor_data_ be non-empty when you get here?

https://codereview.chromium.org/888783002/diff/20001/ui/compositor/test/in_pr...
File ui/compositor/test/in_process_context_factory.h (right):

https://codereview.chromium.org/888783002/diff/20001/ui/compositor/test/in_pr...
ui/compositor/test/in_process_context_factory.h:26: cc::SurfaceManager*
surface_manager);
nit: document ownership.

[jbauman, 2015-02-03 01:47:21]

https://codereview.chromium.org/888783002/diff/20001/ui/compositor/test/in_pr...
File ui/compositor/test/in_process_context_factory.cc (right):

https://codereview.chromium.org/888783002/diff/20001/ui/compositor/test/in_pr...
ui/compositor/test/in_process_context_factory.cc:90:
InProcessContextFactory::~InProcessContextFactory() {}
On 2015/02/03 00:44:58, sky wrote:
> Might per_compositor_data_ be non-empty when you get here?

Added a DCHECK that it's empty - all compositors should be removed before this
is deleted.

https://codereview.chromium.org/888783002/diff/20001/ui/compositor/test/in_pr...
File ui/compositor/test/in_process_context_factory.h (right):

https://codereview.chromium.org/888783002/diff/20001/ui/compositor/test/in_pr...
ui/compositor/test/in_process_context_factory.h:26: cc::SurfaceManager*
surface_manager);
On 2015/02/03 00:44:58, sky wrote:
> nit: document ownership.

Done.

[sky, 2015-02-03 03:59:15]

LGTM

[jbauman, 2015-02-03 04:05:10]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2015-02-03 04:06:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/888783002/40001

[commit-bot: I haz the power, 2015-02-03 04:55:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-03 04:56:36]

Patchset 3 (id:??) landed as
https://crrev.com/f400ce53d5f5dfe57d0f533ae1b86e19c7ad72c6
Cr-Commit-Position: refs/heads/master@{#314269}