LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html - Issue 888743002: Force unitless data-expected attributes

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html

Issue 888743002: Force unitless data-expected attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix percentage-height-when-height-specified-by-top-bottom.html Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/box-sizing/table-no-collapse.html ('k') | LayoutTests/fast/css/calc-rounding.html » ('j') | LayoutTests/fast/replaced/percentage-height-when-height-specified-by-top-bottom.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html b/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html

index 27c1d52440ce7d8758cac42360fcab79ca2c0fc6..6b316d5a4a3b02198d9eb96e56536b74e8265a78 100644

--- a/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html

+++ b/LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html

@@ -147,61 +147,61 @@

- <div class="sizedToGridArea" style="grid-column: 4 / auto;" data-offset-x="60px" data-expected-width="40px"></div>

+ <div class="sizedToGridArea" style="grid-column: 4 / auto;" data-offset-x="60px" data-expected-width="40"></div>

</div>

- <div class="sizedToGridArea" style="grid-column: auto / 6;" data-offset-x="100px" data-expected-width="50px"></div>

+ <div class="sizedToGridArea" style="grid-column: auto / 6;" data-offset-x="100px" data-expected-width="50"></div>

</div>

- <div class="sizedToGridArea" style="grid-column: C / C -1;" data-offset-x="30px" data-expected-width="330px"></div>

+ <div class="sizedToGridArea" style="grid-column: C / C -1;" data-offset-x="30px" data-expected-width="330"></div>

</div>

- <div class="sizedToGridArea" style="grid-column: C / span C;" data-offset-x="30px" data-expected-width="120px"></div>

+ <div class="sizedToGridArea" style="grid-column: C / span C;" data-offset-x="30px" data-expected-width="120"></div>

</div>

- <div class="sizedToGridArea" style="grid-column: span C / C -1;" data-offset-x="150px" data-expected-width="210px"></div>

+ <div class="sizedToGridArea" style="grid-column: span C / C -1;" data-offset-x="150px" data-expected-width="210"></div>

</div>

- <div class="sizedToGridArea" style="grid-column: span C / span C;" data-offset-x="0px" data-expected-width="10px"></div>

+ <div class="sizedToGridArea" style="grid-column: span C / span C;" data-offset-x="0px" data-expected-width="10"></div>

</div>

- <div class="sizedToGridArea" style="grid-column: 5 / C -1;" data-offset-x="100px" data-expected-width="260px"></div>

+ <div class="sizedToGridArea" style="grid-column: 5 / C -1;" data-offset-x="100px" data-expected-width="260"></div>

</div>

- <div class="sizedToGridArea" style="grid-column: 5 / span C;" data-offset-x="100px" data-expected-width="50px"></div>

+ <div class="sizedToGridArea" style="grid-column: 5 / span C;" data-offset-x="100px" data-expected-width="50"></div>

Julien - ping for review 2015/01/31 07:12:55 Isn't data-offset-* plagued with the same issue?

</div>

- <div class="sizedToGridArea" style="grid-column: 8 / 8;" data-offset-x="280px" data-expected-width="80px"></div>

+ <div class="sizedToGridArea" style="grid-column: 8 / 8;" data-offset-x="280px" data-expected-width="80"></div>

</div>

- <div class="sizedToGridArea" style="grid-column: B 2 / span 1;" data-offset-x="100px" data-expected-width="50px"></div>

+ <div class="sizedToGridArea" style="grid-column: B 2 / span 1;" data-offset-x="100px" data-expected-width="50"></div>

</div>