LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html - Issue 888743002: Force unitless data-expected attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html

Issue 888743002: Force unitless data-expected attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Redo percentage-height-when-height-specified-by-top-bottom.html onload change Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/css3/flexbox/flexitem.html ('k') | LayoutTests/fast/block/min-max-height-percent-height-child.html » ('j') | LayoutTests/fast/css-grid-layout/grid-align.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html

diff --git a/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html b/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html

index b281d9fcbd69c02df27a3c70bbe787d1de837faa..964d3223329267780ddd76c7ee05d32618477de9 100644

--- a/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html

+++ b/LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-float-children.html

@@ -19,9 +19,9 @@

<body>

- <li class="floated-child" data-offset-y="30px">These words should</li>

- <li class="floated-child" data-offset-y="30px">be all on the </li>

- <li class="floated-child" data-offset-y="30px">same line.</li>

+ <li class="floated-child" data-offset-y="30">These words should</li>

+ <li class="floated-child" data-offset-y="30">be all on the </li>

+ <li class="floated-child" data-offset-y="30">same line.</li>

</ul>

<p> https://bugs.webkit.org/show_bug.cgi?id=109476 : only the first floated child of a self-collapsing block needs to account

for its collapsed margin. </p>