LayoutTests/fast/replaced/percentage-height-when-height-specified-by-top-bottom.html - Issue 888743002: Force unitless data-expected attributes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/replaced/percentage-height-when-height-specified-by-top-bottom.html

Issue 888743002: Force unitless data-expected attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix percentage-height-when-height-specified-by-top-bottom.html Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype HTML>	1 <!doctype HTML>

2 <style>	2 <style>

3 #outer {	3 #outer {

4 height: 50px;	4 height: 50px;

5 outline: 1px solid;	5 outline: 1px solid;

6 position:relative;	6 position:relative;

7 }	7 }

8 #inner { top:0; bottom:0; position:absolute; }	8 #inner { top:0; bottom:0; position:absolute; }

9 img { max-height: 100%; }	9 img { max-height: 100%; }

10 </style>	10 </style>

11 <script src="../../resources/check-layout.js"></script>	11 <script src="../../resources/check-layout.js"></script>

	12 <body onload="checkLayout('#img')">

12 <div id="outer">	13 <div id="outer">

13 <div id="inner">	14 <div id="inner">

14 <img src="resources/square-blue-100x100.png" id="img" data-expected-clie nt-height="50px">	15 <img src="resources/square-blue-100x100.png" id="img" data-expected-clie nt-height="50">

15 </div>	16 </div>

16 </div>	17 </div>

17 <script>	18 </body>

18 window.checkLayout("#img");

19 </script>
Julien - ping for review 2015/01/31 07:12:55 I don't think that makes a difference in the test. I don't think that makes a difference in the test.
OLD	NEW