Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-align.html

Issue 888743002: Force unitless data-expected attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Redo percentage-height-when-height-specified-by-top-bottom.html onload change Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/box-sizing/table-no-collapse.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html » ('j') | LayoutTests/resources/check-layout.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <link href="resources/grid.css" rel="stylesheet"> 4 <link href="resources/grid.css" rel="stylesheet">
5 <script src="../../resources/check-layout.js"></script> 5 <script src="../../resources/check-layout.js"></script>
6 <style> 6 <style>
7 body { 7 body {
8 margin: 0; 8 margin: 0;
9 } 9 }
10 10
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 <div class="cell alignSelfRight secondRowSecondColumn" data-offset-x="8 0" data-offset-y="200" data-expected-width="20" data-expected-height="40"></div> 129 <div class="cell alignSelfRight secondRowSecondColumn" data-offset-x="8 0" data-offset-y="200" data-expected-width="20" data-expected-height="40"></div>
130 <div class="cell alignSelfLeft secondRowSecondColumn" data-offset-x="80 " data-offset-y="200" data-expected-width="20" data-expected-height="40"></div> 130 <div class="cell alignSelfLeft secondRowSecondColumn" data-offset-x="80 " data-offset-y="200" data-expected-width="20" data-expected-height="40"></div>
131 </div> 131 </div>
132 </div> 132 </div>
133 133
134 <div style="position: relative"> 134 <div style="position: relative">
135 <div class="grid directionRTL" data-expected-width="200" data-expected-heig ht="400"> 135 <div class="grid directionRTL" data-expected-width="200" data-expected-heig ht="400">
136 <div class="cell alignSelfFlexEnd firstRowFirstColumn" data-offset-x="1 80" data-offset-y="160" data-expected-width="20" data-expected-height="40"></div > 136 <div class="cell alignSelfFlexEnd firstRowFirstColumn" data-offset-x="1 80" data-offset-y="160" data-expected-width="20" data-expected-height="40"></div >
137 <div class="cell alignSelfFlexStart firstRowSecondColumn" data-offset-x ="80" data-offset-y="0" data-expected-width="20" data-expected-height="40"></div > 137 <div class="cell alignSelfFlexStart firstRowSecondColumn" data-offset-x ="80" data-offset-y="0" data-expected-width="20" data-expected-height="40"></div >
138 <div class="cell alignSelfSelfStart secondRowFirstColumn" data-offset-x ="180" data-offset-y="200" data-expected-width="20" data-expected-height="40"></ div> 138 <div class="cell alignSelfSelfStart secondRowFirstColumn" data-offset-x ="180" data-offset-y="200" data-expected-width="20" data-expected-height="40"></ div>
139 <div class="cell alignSelfSelfEnd secondRowSecondColumn" data-offset-x= "x80" data-offset-y="360" data-expected-width="20" data-expected-height="40"></d iv> 139 <div class="cell alignSelfSelfEnd secondRowSecondColumn" data-offset-x= "80" data-offset-y="360" data-expected-width="20" data-expected-height="40"></di v>
Julien - ping for review 2015/02/03 02:42:53 Nice catch!
140 </div> 140 </div>
141 </div> 141 </div>
142 142
143 <!-- RTL direction (it should not affect the block-flow) with opposite direction s grid container vs grid item. --> 143 <!-- RTL direction (it should not affect the block-flow) with opposite direction s grid container vs grid item. -->
144 <div style="position: relative"> 144 <div style="position: relative">
145 <div class="grid" data-expected-width="200" data-expected-height="400"> 145 <div class="grid" data-expected-width="200" data-expected-height="400">
146 <div class="alignSelfStretch firstRowFirstColumn directionRTL" data-off set-x="0" data-offset-y="0" data-expected-width="100" data-expected-height="200" ></div> 146 <div class="alignSelfStretch firstRowFirstColumn directionRTL" data-off set-x="0" data-offset-y="0" data-expected-width="100" data-expected-height="200" ></div>
147 <div class="cell alignSelfStart firstRowSecondColumn directionRTL" data -offset-x="100" data-offset-y="0" data-expected-width="20" data-expected-height= "40"></div> 147 <div class="cell alignSelfStart firstRowSecondColumn directionRTL" data -offset-x="100" data-offset-y="0" data-expected-width="20" data-expected-height= "40"></div>
148 <div class="cell alignSelfEnd firstRowSecondColumn directionRTL" data-o ffset-x="100" data-offset-y="160" data-expected-width="20" data-expected-height= "40"></div> 148 <div class="cell alignSelfEnd firstRowSecondColumn directionRTL" data-o ffset-x="100" data-offset-y="160" data-expected-width="20" data-expected-height= "40"></div>
149 <div class="cell alignSelfCenter secondRowFirstColumn directionRTL" dat a-offset-x="0" data-offset-y="280" data-expected-width="20" data-expected-height ="40"></div> 149 <div class="cell alignSelfCenter secondRowFirstColumn directionRTL" dat a-offset-x="0" data-offset-y="280" data-expected-width="20" data-expected-height ="40"></div>
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 <div class="item"></div> 278 <div class="item"></div>
279 </div> 279 </div>
280 <div class="cell alignSelfSelfEnd secondRowSecondColumn verticalRL" data -offset-x="200" data-offset-y="100" data-expected-width="20" data-expected-heigh t="40"> 280 <div class="cell alignSelfSelfEnd secondRowSecondColumn verticalRL" data -offset-x="200" data-offset-y="100" data-expected-width="20" data-expected-heigh t="40">
281 <div class="item"></div> 281 <div class="item"></div>
282 </div> 282 </div>
283 </div> 283 </div>
284 </div> 284 </div>
285 285
286 </body> 286 </body>
287 </html> 287 </html>
OLDNEW
« no previous file with comments | « LayoutTests/fast/box-sizing/table-no-collapse.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html » ('j') | LayoutTests/resources/check-layout.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698