Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 888713003: Add param_after_rest error message after r26362 (Closed)

Created:
5 years, 10 months ago by caitp (gmail)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add param_after_rest error message after r26362 BUG=v8:2159 LOG=N R=marja@chromium.org, arv@chromium.org Committed: https://crrev.com/f6f56de8e3856f988f39d51884948ccd03957601 Cr-Commit-Position: refs/heads/master@{#26366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/messages.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
caitp (gmail)
PTAL --- trivial fixup, I didn't realize the message wasn't included in the other CL
5 years, 10 months ago (2015-01-30 16:15:41 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 10 months ago (2015-01-30 16:45:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888713003/1
5 years, 10 months ago (2015-01-30 16:47:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 17:18:45 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 17:19:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6f56de8e3856f988f39d51884948ccd03957601
Cr-Commit-Position: refs/heads/master@{#26366}

Powered by Google App Engine
This is Rietveld 408576698