components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc - Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Webview fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

index f8be3741a8db30891dc9ec31d91cd2e539cb0ecb..b588554ae0d08098af5c1295f6fead5a2c21e8c0 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

@@ -29,6 +29,8 @@ const char kProbeURLWithNoResponse[] = "http://no.org/";

namespace data_reduction_proxy {

+class DataReductionProxyStatisticsPrefs;

class DataReductionProxySettingsTest

: public ConcreteDataReductionProxySettingsTest<

DataReductionProxySettings> {

@@ -423,6 +425,7 @@ TEST_F(DataReductionProxySettingsTest, CheckInitMetricsWhenNotAllowed) {

new net::TestURLRequestContextGetter(base::MessageLoopProxy::current());

settings_->InitDataReductionProxySettings(

&pref_service_,

+ scoped_ptr<DataReductionProxyStatisticsPrefs>(),

request_context.get(),

&net_log_,

event_store_.get());